You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/21 01:31:42 UTC
[GitHub] [pulsar] ethqunzhong opened a new pull request, #17502: [improve][admin]namespace CLI set-offload-policy's thresholdBytes support negative and 0
ethqunzhong opened a new pull request, #17502:
URL: https://github.com/apache/pulsar/pull/17502
### Motivation
we could set namespace level offload-policy's offload-threshold In the following two `pulsar-admin CLI` ways:
1. `pulsar-admin namespaces set-offload-threshold -s $OFFLOAD_THRESHOLD demo/demo`
2. `pulsar-admin namespaces set-offload-policies --offloadAfterThreshold $OFFLOAD_THRESHOLD demo/demo`
while set offload-threshold value , Negative values disable automatic offload. 0 triggers offloading as soon as possible.
but we can't use `pulsar-admin namespaces set-offload-policies` to set offload-threshold'value to negative or 0 , show as follow：
<img width="1073" alt="image" src="https://user-images.githubusercontent.com/16517186/188781816-1f9ecb6b-69e6-4436-af9a-a56aaf9a3dfe.png">
`pulsar-admin namespaces set-offload-threshold` as expected.
we should keep `set-offload-threshold` and `set-offload-policies` CLI behavior consistent.
### Modifications
remove `positiveCheck` process while check offloadAfterThreshold value validity at `CmdNamespaces#SetOffloadPolicies`.
### Does this pull request potentially affect one of the following parts:
_If `yes` was chosen, please highlight the changes_
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [x] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ethqunzhong commented on pull request #17502: [improve][admin]namespace CLI set-offload-policy's thresholdBytes support negative and 0
Posted by GitBox <gi...@apache.org>.
ethqunzhong commented on PR #17502:
URL: https://github.com/apache/pulsar/pull/17502#issuecomment-1246609961
@Technoboy- ready to merged. PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ethqunzhong commented on pull request #17502: [improve][admin]namespace CLI set-offload-policy's thresholdBytes support negative and 0
Posted by GitBox <gi...@apache.org>.
ethqunzhong commented on PR #17502:
URL: https://github.com/apache/pulsar/pull/17502#issuecomment-1240062651
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ethqunzhong commented on pull request #17502: [improve][admin]namespace CLI set-offload-policy's thresholdBytes support negative and 0
Posted by GitBox <gi...@apache.org>.
ethqunzhong commented on PR #17502:
URL: https://github.com/apache/pulsar/pull/17502#issuecomment-1246605817
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hangc0276 closed pull request #17502: [improve][admin]namespace CLI set-offload-policy's thresholdBytes support negative and 0
Posted by GitBox <gi...@apache.org>.
hangc0276 closed pull request #17502: [improve][admin]namespace CLI set-offload-policy's thresholdBytes support negative and 0
URL: https://github.com/apache/pulsar/pull/17502
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ethqunzhong commented on pull request #17502: namespace CLI set-offload-policy's thresholdBytes support negative and 0
Posted by GitBox <gi...@apache.org>.
ethqunzhong commented on PR #17502:
URL: https://github.com/apache/pulsar/pull/17502#issuecomment-1238865496
@Technoboy- @zymap @hangc0276 PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ethqunzhong commented on pull request #17502: [improve][admin]namespace CLI set-offload-policy's thresholdBytes support negative and 0
Posted by GitBox <gi...@apache.org>.
ethqunzhong commented on PR #17502:
URL: https://github.com/apache/pulsar/pull/17502#issuecomment-1245317990
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ethqunzhong commented on pull request #17502: [improve][admin]namespace CLI set-offload-policy's thresholdBytes support negative and 0
Posted by GitBox <gi...@apache.org>.
ethqunzhong commented on PR #17502:
URL: https://github.com/apache/pulsar/pull/17502#issuecomment-1250165816
@codelipenghui ready to merged. PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ethqunzhong commented on pull request #17502: [improve][admin]namespace CLI set-offload-policy's thresholdBytes support negative and 0
Posted by GitBox <gi...@apache.org>.
ethqunzhong commented on PR #17502:
URL: https://github.com/apache/pulsar/pull/17502#issuecomment-1239329415
@hangc0276 @zymap @Technoboy- This patch is ready to merge. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ethqunzhong commented on pull request #17502: [improve][admin]namespace CLI set-offload-policy's thresholdBytes support negative and 0
Posted by GitBox <gi...@apache.org>.
ethqunzhong commented on PR #17502:
URL: https://github.com/apache/pulsar/pull/17502#issuecomment-1239064572
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ethqunzhong commented on pull request #17502: [improve][admin]namespace CLI set-offload-policy's thresholdBytes support negative and 0
Posted by GitBox <gi...@apache.org>.
ethqunzhong commented on PR #17502:
URL: https://github.com/apache/pulsar/pull/17502#issuecomment-1244822129
it seems pass all CI, ready to merged. PTAL @zymap
<img width="1843" alt="image" src="https://user-images.githubusercontent.com/16517186/189795125-aee760f9-7f3b-45b2-a9f2-384c2a8de1fd.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- merged pull request #17502: [improve][admin]namespace CLI set-offload-policy's thresholdBytes support negative and 0
Posted by GitBox <gi...@apache.org>.
Technoboy- merged PR #17502:
URL: https://github.com/apache/pulsar/pull/17502
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org