You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@climate.apache.org by lewismc <gi...@git.apache.org> on 2018/06/29 21:43:47 UTC
[GitHub] climate pull request #516: CLIMATE-958 Disable Pydap for Python 2 build, act...
GitHub user lewismc opened a pull request:
https://github.com/apache/climate/pull/516
CLIMATE-958 Disable Pydap for Python 2 build, activate for Python 3 build
Addresses https://issues.apache.org/jira/browse/CLIMATE-958
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lewismc/climate CLIMATE-958
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/climate/pull/516.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #516
----
commit a3b65da98bbb80a02f1f15bb6495bf549e39de56
Author: Lewis John McGibbney <le...@...>
Date: 2018-06-29T21:42:03Z
CLIMATE-958 Disable Pydap for Python 2 build, activate for Python 3 build
----
---
[GitHub] climate pull request #516: CLIMATE-958 Disable Pydap for Python 2 build, act...
Posted by prateekiiest <gi...@git.apache.org>.
Github user prateekiiest commented on a diff in the pull request:
https://github.com/apache/climate/pull/516#discussion_r199679510
--- Diff: ocw/tests/test_dap.py ---
@@ -17,11 +17,14 @@
import unittest
import datetime as dt
-import ocw.data_source.dap as dap
+try:
+ import ocw.data_source.dap as dap
+except ImportError:
--- End diff --
looks good @lewismc 🎆
This will probably solve the problem
---
[GitHub] climate pull request #516: CLIMATE-958 Disable Pydap for Python 2 build, act...
Posted by prateekiiest <gi...@git.apache.org>.
Github user prateekiiest commented on a diff in the pull request:
https://github.com/apache/climate/pull/516#discussion_r199679566
--- Diff: ocw/tests/test_dap.py ---
@@ -17,11 +17,14 @@
import unittest
import datetime as dt
-import ocw.data_source.dap as dap
+try:
+ import ocw.data_source.dap as dap
+except ImportError:
--- End diff --
Are there any tests that need such skipping, let me know about it. I can work on it then
---