You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by sandhyasun <gi...@git.apache.org> on 2017/05/04 06:11:59 UTC
[GitHub] incubator-trafodion pull request #1083: [TRAFODION-2098] Move all hdfs direc...
GitHub user sandhyasun opened a pull request:
https://github.com/apache/incubator-trafodion/pull/1083
[TRAFODION-2098] Move all hdfs directories trafodion needs/uses uder /user/trafodion
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sandhyasun/incubator-trafodion hdfs_chdir_work
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/1083.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1083
----
commit f094aa0d144046118253b4642a038b5ea5446ae4
Author: Sandhya Sundaresan <sa...@edev08.esgyn.local>
Date: 2017-05-02T17:16:45Z
Changes to move all Trafodion created hdfs files under /user/trafodion
commit 4b27589acaf0ab0861f3a892735ea2ce9b165d27
Author: Sandhya Sundaresan <sa...@edev08.esgyn.local>
Date: 2017-05-02T17:29:42Z
Merge remote branch 'origin/master' into hdfs_chdir_work
Conflicts:
core/sql/regress/executor/TEST130
commit a14a3ee1040fb62c149a2888e8a94bcce4095f4b
Author: Sandhya Sundaresan <sa...@edev08.esgyn.local>
Date: 2017-05-04T05:52:10Z
Expected file change for TEST130
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #1083: [TRAFODION-2098] Move all hdfs direc...
Posted by sandhyasun <gi...@git.apache.org>.
Github user sandhyasun commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1083#discussion_r115075645
--- Diff: core/sql/sqlcomp/nadefaults.cpp ---
@@ -3378,7 +3378,7 @@ XDDkwd__(SUBQUERY_UNNESTING, "ON"),
DDkwd__(TRAF_READ_OBJECT_DESC, "OFF"),
DDkwd__(TRAF_RELOAD_NATABLE_CACHE, "OFF"),
- DD_____(TRAF_SAMPLE_TABLE_LOCATION, "/sample/"),
--- End diff --
Barry and Dave worked on this sample feature for ustat. WIll let them decide.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #1083: [TRAFODION-2098] Move all hdfs direc...
Posted by selvaganesang <gi...@git.apache.org>.
Github user selvaganesang commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1083#discussion_r115023412
--- Diff: core/sql/sqlcomp/nadefaults.cpp ---
@@ -1956,7 +1956,7 @@ SDDkwd__(EXE_DIAGNOSTIC_EVENTS, "OFF"),
DDkwd__(HIVE_DEFAULT_CHARSET, (char *)SQLCHARSETSTRING_UTF8),
DD_____(HIVE_DEFAULT_SCHEMA, "HIVE"),
DD_____(HIVE_FILE_CHARSET, ""),
- DD_____(HIVE_FILE_NAME, "/hive/tpcds/customer/customer.dat" ),
--- End diff --
Do you now why is it a specific table name is used as a default?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #1083: [TRAFODION-2098] Move all hdfs direc...
Posted by selvaganesang <gi...@git.apache.org>.
Github user selvaganesang commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1083#discussion_r115024297
--- Diff: core/sql/sqlcomp/nadefaults.cpp ---
@@ -3378,7 +3378,7 @@ XDDkwd__(SUBQUERY_UNNESTING, "ON"),
DDkwd__(TRAF_READ_OBJECT_DESC, "OFF"),
DDkwd__(TRAF_RELOAD_NATABLE_CACHE, "OFF"),
- DD_____(TRAF_SAMPLE_TABLE_LOCATION, "/sample/"),
--- End diff --
Would be good to come up with a different location rather than sample. The name 'sample' connotes to kind of example table which might be deleted unknowingly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #1083: [TRAFODION-2098] Move all hdfs direc...
Posted by sandhyasun <gi...@git.apache.org>.
Github user sandhyasun commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1083#discussion_r115075332
--- Diff: core/sql/sqlcomp/nadefaults.cpp ---
@@ -1956,7 +1956,7 @@ SDDkwd__(EXE_DIAGNOSTIC_EVENTS, "OFF"),
DDkwd__(HIVE_DEFAULT_CHARSET, (char *)SQLCHARSETSTRING_UTF8),
DD_____(HIVE_DEFAULT_SCHEMA, "HIVE"),
DD_____(HIVE_FILE_CHARSET, ""),
- DD_____(HIVE_FILE_NAME, "/hive/tpcds/customer/customer.dat" ),
--- End diff --
The CQD is not used anymore so removed it. Must have been some prototype code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #1083: [TRAFODION-2098] Move all hdfs direc...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/1083
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---