[plc4x] 03/04: - Disabled some test that require explicits serial ports to exist

[cd...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

cdutz pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/plc4x.git

commit 511b95f63c84a1e66332fe72728953e967c5e322
Author: Christofer Dutz <ch...@c-ware.de>
AuthorDate: Mon Apr 6 10:48:06 2020 +0200

    - Disabled some test that require explicits serial ports to exist
---
 .../apache/plc4x/java/base/connection/SerialChannelFactoryTest.java  | 2 ++
 .../src/test/java/org/apache/plc4x/protocol/amsads/EndToEndTest.java | 5 +++--
 .../src/test/java/org/apache/plc4x/protocol/df1/EndToEndTest.java    | 2 ++
 3 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/plc4j/transports/serial/src/test/java/org/apache/plc4x/java/base/connection/SerialChannelFactoryTest.java b/plc4j/transports/serial/src/test/java/org/apache/plc4x/java/base/connection/SerialChannelFactoryTest.java
index 01bfb9e..491fc78 100644
--- a/plc4j/transports/serial/src/test/java/org/apache/plc4x/java/base/connection/SerialChannelFactoryTest.java
+++ b/plc4j/transports/serial/src/test/java/org/apache/plc4x/java/base/connection/SerialChannelFactoryTest.java
@@ -30,6 +30,7 @@ import org.apache.plc4x.java.transport.serial.SerialChannel;
 import org.apache.plc4x.java.transport.serial.SerialChannelFactory;
 import org.apache.plc4x.java.transport.serial.SerialChannelHandler;
 import org.apache.plc4x.java.transport.serial.SerialSocketAddress;
+import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
@@ -77,6 +78,7 @@ public class SerialChannelFactoryTest {
     }
 
     @Test
+    @Disabled("Seems to cause problems on Windows, but as it generally only woks on devices with a 'JBLFlip3-SPPDev' it's not much use anyway")
     public void createChannelToSBL() throws PlcConnectionException, InterruptedException, UnknownHostException {
         SerialChannelFactory asdf = new SerialChannelFactory(new SerialSocketAddress("JBLFlip3-SPPDev"));
         Channel channel = null;
diff --git a/sandbox/test-java-amsads-driver/src/test/java/org/apache/plc4x/protocol/amsads/EndToEndTest.java b/sandbox/test-java-amsads-driver/src/test/java/org/apache/plc4x/protocol/amsads/EndToEndTest.java
index 42e2635..0927985 100644
--- a/sandbox/test-java-amsads-driver/src/test/java/org/apache/plc4x/protocol/amsads/EndToEndTest.java
+++ b/sandbox/test-java-amsads-driver/src/test/java/org/apache/plc4x/protocol/amsads/EndToEndTest.java
@@ -17,13 +17,13 @@
  * under the License.
  */
 
-package org.apache.plc4x.protocol.df1;
+package org.apache.plc4x.protocol.amsads;
 
 import org.apache.plc4x.java.PlcDriverManager;
 import org.apache.plc4x.java.api.PlcConnection;
-import org.apache.plc4x.java.api.exceptions.PlcConnectionException;
 import org.apache.plc4x.java.api.messages.PlcReadRequest;
 import org.apache.plc4x.java.api.messages.PlcReadResponse;
+import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 
 import java.util.concurrent.TimeUnit;
@@ -37,6 +37,7 @@ import java.util.concurrent.TimeUnit;
 public class EndToEndTest {
 
     @Test
+    @Disabled("Seems to cause problems on Windows if no COM4 is available")
     public void helloDf1() {
         try (PlcConnection plcConnection = new PlcDriverManager().getConnection("df1:serial:///COM4")) {
             PlcReadRequest request = plcConnection.readRequestBuilder()
diff --git a/sandbox/test-java-df1-driver/src/test/java/org/apache/plc4x/protocol/df1/EndToEndTest.java b/sandbox/test-java-df1-driver/src/test/java/org/apache/plc4x/protocol/df1/EndToEndTest.java
index 42e2635..55d1a52 100644
--- a/sandbox/test-java-df1-driver/src/test/java/org/apache/plc4x/protocol/df1/EndToEndTest.java
+++ b/sandbox/test-java-df1-driver/src/test/java/org/apache/plc4x/protocol/df1/EndToEndTest.java
@@ -24,6 +24,7 @@ import org.apache.plc4x.java.api.PlcConnection;
 import org.apache.plc4x.java.api.exceptions.PlcConnectionException;
 import org.apache.plc4x.java.api.messages.PlcReadRequest;
 import org.apache.plc4x.java.api.messages.PlcReadResponse;
+import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 
 import java.util.concurrent.TimeUnit;
@@ -37,6 +38,7 @@ import java.util.concurrent.TimeUnit;
 public class EndToEndTest {
 
     @Test
+    @Disabled("Seems to cause problems on Windows if no COM4 is available")
     public void helloDf1() {
         try (PlcConnection plcConnection = new PlcDriverManager().getConnection("df1:serial:///COM4")) {
             PlcReadRequest request = plcConnection.readRequestBuilder()