You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Duo Zhang (Jira)" <ji...@apache.org> on 2019/08/27 13:37:00 UTC

[jira] [Updated] (HBASE-22933) Do not need to kick reassign for rs group change any more

     [ https://issues.apache.org/jira/browse/HBASE-22933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Duo Zhang updated HBASE-22933:
------------------------------
    Component/s: rsgroup

> Do not need to kick reassign for rs group change any more
> ---------------------------------------------------------
>
>                 Key: HBASE-22933
>                 URL: https://issues.apache.org/jira/browse/HBASE-22933
>             Project: HBase
>          Issue Type: Improvement
>          Components: rsgroup
>            Reporter: Duo Zhang
>            Priority: Major
>
> The old implementation is a bit strange, the isStuck method is like this:
> {code}
>   public boolean isStuck() {
>     return isInState(State.FAILED_OPEN) && getProcedure() != null;
>   }
> {code}
> It can only return true when there are ongoing procedures. But if we have a procedure, then the procedure will try to reassign region. Scheduling a new procedure does not make sense here, at least for branch-2.2+.
> I suggest we just remove the related code, since the default retry number for assigning a region is Integer.MAX_VALUE. And even if user set this to small value and finally the region is left in FAILED_OPEN state without a procedure, HBCK2 is used to deal with this, it is not necessary to deal it automatically.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)