You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/05/13 20:35:47 UTC
[GitHub] [spark] liyinan926 commented on a change in pull request #28518: [SPARK-31696][K8S] Support driver service annotation in K8S
liyinan926 commented on a change in pull request #28518:
URL: https://github.com/apache/spark/pull/28518#discussion_r424715315
##########
File path: docs/running-on-kubernetes.md
##########
@@ -816,6 +816,15 @@ See the [configuration page](configuration.html) for information on Spark config
</td>
<td>2.3.0</td>
</tr>
+<tr>
+ <td><code>spark.kubernetes.driver.service.annotation.[AnnotationName]</code></td>
+ <td>(none)</td>
+ <td>
+ Add the annotation specified by <code>AnnotationName</code> to the driver service.
Review comment:
Nit: may worth mentioning "Kubernetes annotations" and adding a link to the Kubernetes doc on annotations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org