[GitHub] [airflow] feluelle commented on a change in pull request #5786: [AIRFLOW-5170] [AIRFLOW-5256] Consistent licences for python files and related pylint fixes

[GitBox <gi...@apache.org>]

feluelle commented on a change in pull request #5786:  [AIRFLOW-5170] [AIRFLOW-5256] Consistent licences for python files and related pylint fixes
URL: https://github.com/apache/airflow/pull/5786#discussion_r320015877
 
 

 ##########
 File path: airflow/migrations/versions/33ae817a1ff4_add_kubernetes_resource_checkpointing.py
 ##########
 @@ -44,11 +44,11 @@ def upgrade():
     conn = op.get_bind()
 
     # alembic creates an invalid SQL for mssql and mysql dialects
-    if conn.dialect.name in ("mysql"):
+    if conn.dialect.name in {"mysql"}:
 
 Review comment:
   Agree with you. I am fine with changing this if it fixes an issue.
   
   But wouldn't that mean that every time we are re-running alembic we need to make this change? (sorry, haven't looked into alembic at all)
   What gets actually auto generated?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services