Program.prefix returns null for all regex

[Simon Willnauer <si...@googlemail.com>]

Hey there,

I'm working on Apache Lucene upgrading the regex contrib to
jakarta-regex-1.5. I upgraded to make use of the added Program#prefix
getter. Yet, this getter always returns null for me even if there
would be a common prefix. My understanding is when I compile a regex
"luce.+"  -> "luce" should be returned by Program#prefix(). Is that a
bug or do I miss something essential?
Btw. the 1.4 version works as expected.

simon

---------------------------------------------------------------------
To unsubscribe, e-mail: regexp-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: regexp-dev-help@jakarta.apache.org

Re: Program.prefix returns null for all regex

[Simon Willnauer <si...@googlemail.com>]

Hi Vadim, sorry for the late answer. Thanks for fixing this quickly
though. I would have attached a testcase but afaik you guys do not
have a junit infra in your project. I was kind of afraid of the
RETest.java :)
maybe we can work together towards a junit based test infra, not that
much of a deal patching your build.xml though.
I'm kind of confused about your infra anyway as you guys still use bugzilla?!
Anyway, I try to come up with a patch until the end of the year - ha!
need a bugzilla account first :)....

Do you have any idea when the next release for regexp will be
released? For us (lucene) this would be the only way to upgrade
because without the prefix feature commons-regexp has no advantage
over the jdk regex impl though.

simon

On Sun, Dec 13, 2009 at 12:23 AM, Vadim Gritsenko <va...@reverycodes.com> wrote:
> On Nov 22, 2009, at 3:06 PM, Simon Willnauer wrote:
>
>> I'm working on Apache Lucene upgrading the regex contrib to
>> jakarta-regex-1.5. I upgraded to make use of the added Program#prefix
>> getter. Yet, this getter always returns null for me even if there
>> would be a common prefix. My understanding is when I compile a regex
>> "luce.+"  -> "luce" should be returned by Program#prefix(). Is that a
>> bug or do I miss something essential?
>
> I think that's a bug. There were no test cases which would exercise this feature, so it was an easy one to make too. I think I fixed this in svn r890007, would you mind testing how it works for you?
>
> I'd also appreciate a patch for the test cases, to make sure functionality stays correct :)
>
>
> Thanks,
> Vadim

---------------------------------------------------------------------
To unsubscribe, e-mail: regexp-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: regexp-dev-help@jakarta.apache.org

Re: Program.prefix returns null for all regex

[Vadim Gritsenko <va...@reverycodes.com>]

On Nov 22, 2009, at 3:06 PM, Simon Willnauer wrote:

> I'm working on Apache Lucene upgrading the regex contrib to
> jakarta-regex-1.5. I upgraded to make use of the added Program#prefix
> getter. Yet, this getter always returns null for me even if there
> would be a common prefix. My understanding is when I compile a regex
> "luce.+"  -> "luce" should be returned by Program#prefix(). Is that a
> bug or do I miss something essential?

I think that's a bug. There were no test cases which would exercise this feature, so it was an easy one to make too. I think I fixed this in svn r890007, would you mind testing how it works for you?

I'd also appreciate a patch for the test cases, to make sure functionality stays correct :)


Thanks,
Vadim
---------------------------------------------------------------------
To unsubscribe, e-mail: regexp-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: regexp-dev-help@jakarta.apache.org