[jira] [Commented] (CALCITE-1482) Resource leak on creation of CassandraSchema

["Julian Hyde (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-1482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15633887#comment-15633887 ] 

Julian Hyde commented on CALCITE-1482:
--------------------------------------

Here is [~michaelmior]'s proposed fix: https://github.com/michaelmior/calcite/commit/aada6f33de92901c6df9be9f0d890903332bf8e4

It looks good to me, at least for the short term. [~maryannxue], Can you please review, and maybe suggest a better long-term solution?

> Resource leak on creation of CassandraSchema
> --------------------------------------------
>
>                 Key: CALCITE-1482
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1482
>             Project: Calcite
>          Issue Type: Bug
>          Components: cassandra
>    Affects Versions: 1.10.0
>            Reporter: Michael Mior
>            Assignee: Michael Mior
>
> Found via the following Coverity scan
> {noformat}
> *** CID 138163:  Resource leaks  (RESOURCE_LEAK)
> /cassandra/src/main/java/org/apache/calcite/adapter/cassandra/CassandraSchema.java: 115 in org.apache.calcite.adapter.cassandra.CassandraSchema.<init>(java.lang.String, java.lang.String, java.lang.String, java.lang.String, org.apache.calcite.schema.SchemaPlus, java.lang.String)()
> 109         } catch (Exception e) {
> 110           throw new RuntimeException(e);
> 111         }
> 112         this.parentSchema = parentSchema;
> 113         this.name  = name;
> 114
> >>    CID 138163:  Resource leaks  (RESOURCE_LEAK)
> >>    Ignoring resource created by "org.apache.calcite.runtime.Hook.TRIMMED.add(this.new org.apache.calcite.adapter.cassandra.CassandraSchema.1())" leaks it.
> 115         Hook.TRIMMED.add(new Function<RelNode, Void>() {
> 116           public Void apply(RelNode node) {
> 117             CassandraSchema.this.addMaterializedViews();
> 118             return null;
> 119           }
> 120         });
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)