You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2018/07/17 19:18:30 UTC
Review Request 67945: Made getters in the Slave class in the allocator
return references.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67945/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Repository: mesos
Description
-------
This eliminates some unnecessary copies.
Diffs
-----
src/master/allocator/mesos/hierarchical.hpp 0f6c0e96a105c64465d3f5db4ff663d8fdfe7e26
Diff: https://reviews.apache.org/r/67945/diff/1/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 67945: Made getters in the Slave class in the
allocator return references.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67945/#review206362
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On July 20, 2018, 11:29 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67945/
> -----------------------------------------------------------
>
> (Updated July 20, 2018, 11:29 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This eliminates some unnecessary copies.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp 702e7c0aa84b4b672d82c759c25a28a77c78ad50
>
>
> Diff: https://reviews.apache.org/r/67945/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 67945: Made getters in the Slave class in the
allocator return references.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67945/
-----------------------------------------------------------
(Updated July 20, 2018, 4:29 p.m.)
Review request for mesos and Benjamin Mahler.
Changes
-------
Rebased.
Repository: mesos
Description
-------
This eliminates some unnecessary copies.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.hpp 702e7c0aa84b4b672d82c759c25a28a77c78ad50
Diff: https://reviews.apache.org/r/67945/diff/2/
Changes: https://reviews.apache.org/r/67945/diff/1-2/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 67945: Made getters in the Slave class in the
allocator return references.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67945/#review206171
-----------------------------------------------------------
PASS: Mesos patch 67945 was successfully built and tested.
Reviews applied: `['67945']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1941/mesos-review-67945
- Mesos Reviewbot Windows
On July 17, 2018, 7:18 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67945/
> -----------------------------------------------------------
>
> (Updated July 17, 2018, 7:18 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This eliminates some unnecessary copies.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp 0f6c0e96a105c64465d3f5db4ff663d8fdfe7e26
>
>
> Diff: https://reviews.apache.org/r/67945/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>