[GitHub] [incubator-superset] willbarrett commented on a change in pull request #10517: feat: make screenshot timeout configurable

[GitBox <gi...@apache.org>]

willbarrett commented on a change in pull request #10517:
URL: https://github.com/apache/incubator-superset/pull/10517#discussion_r465305547



##########
File path: superset/config.py
##########
@@ -799,6 +799,12 @@ class CeleryConfig:  # pylint: disable=too-few-public-methods
 # and render for the email report.
 EMAIL_PAGE_RENDER_WAIT = 30
 
+# Time in seconds before selenium times out after trying to
+# locate an element on the page and wait for that element to
+# load for an alert screenshot.

Review comment:
       Let's add a note in this comment block that this is used for alerting functionality - we may also want to apply the same configuration to report generation if it is not already so.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org