You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/01/25 02:52:41 UTC

[GitHub] [apisix-dashboard] jagerzhang opened a new issue #2294: idle_timeout will be lost when set to 0 in upstream

jagerzhang opened a new issue #2294:
URL: https://github.com/apache/apisix-dashboard/issues/2294


   ### Issue description
   
   see in: https://github.com/apache/apisix/issues/6188
   
   ### Expected behavior
   
   ```
   "keepalive_pool": {
       "idle_timeout": 0,
       "requests": 1000,
       "size": 320
     }
   ```
   
   ### How to Reproduce
   
   1. add a upstream with keepalive_pool:
   ```
   "keepalive_pool": {
       "idle_timeout": 0,
       "requests": 1000,
       "size": 320
     }
   ```
   2. pull upstream with admin-api, idle_timeout was lost
   3. updtea this upstream set idle_timeout =0 with admin-api, idle_timeout  exist
   
   ### Screenshots
   
   _No response_
   
   ### Environment
   
   - apisix version (cmd: `apisix version`):
   - OS (cmd: `uname -a`):
   - OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`):
   - etcd version, if have (cmd: run `etcd --version`):
   - apisix-dashboard version, if have:
   - Browser version, if have:
   
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] zaunist commented on issue #2294: idle_timeout will be lost when set to 0 in upstream

Posted by GitBox <gi...@apache.org>.
zaunist commented on issue #2294:
URL: https://github.com/apache/apisix-dashboard/issues/2294#issuecomment-1020782666


   Hi, @jagerzhang. Because the filed definition https://github.com/apache/apisix-dashboard/blob/bec322aafc02ed79c9a289b66bb7a3de0446768c/api/internal/core/entity/entity.go#L159
   If the filed be set a default value, the filed will be lost. This is indeed a bug, I will fix it later
   @juzhiyuan Please assign to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] bzp2010 commented on issue #2294: idle_timeout will be lost when set to 0 in upstream

Posted by GitBox <gi...@apache.org>.
bzp2010 commented on issue #2294:
URL: https://github.com/apache/apisix-dashboard/issues/2294#issuecomment-1021247826


   > Hi, @jagerzhang. Because the filed definition
   > 
   > https://github.com/apache/apisix-dashboard/blob/bec322aafc02ed79c9a289b66bb7a3de0446768c/api/internal/core/entity/entity.go#L159
   > 
   > 
   > If the filed be set a default value, the filed will be lost. This is indeed a bug, I will fix it later
   > @juzhiyuan Please assign to me.
   
   assigned


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] zaunist commented on issue #2294: idle_timeout will be lost when set to 0 in upstream

Posted by GitBox <gi...@apache.org>.
zaunist commented on issue #2294:
URL: https://github.com/apache/apisix-dashboard/issues/2294#issuecomment-1020782666


   Hi, @jagerzhang. Because the filed definition https://github.com/apache/apisix-dashboard/blob/bec322aafc02ed79c9a289b66bb7a3de0446768c/api/internal/core/entity/entity.go#L159
   If the filed be set a default value, the filed will be lost. This is indeed a bug, I will fix it later
   @juzhiyuan Please assign to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] bzp2010 commented on issue #2294: idle_timeout will be lost when set to 0 in upstream

Posted by GitBox <gi...@apache.org>.
bzp2010 commented on issue #2294:
URL: https://github.com/apache/apisix-dashboard/issues/2294#issuecomment-1021247826


   > Hi, @jagerzhang. Because the filed definition
   > 
   > https://github.com/apache/apisix-dashboard/blob/bec322aafc02ed79c9a289b66bb7a3de0446768c/api/internal/core/entity/entity.go#L159
   > 
   > 
   > If the filed be set a default value, the filed will be lost. This is indeed a bug, I will fix it later
   > @juzhiyuan Please assign to me.
   
   assigned


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] zaunist commented on issue #2294: idle_timeout will be lost when set to 0 in upstream

Posted by GitBox <gi...@apache.org>.
zaunist commented on issue #2294:
URL: https://github.com/apache/apisix-dashboard/issues/2294#issuecomment-1021438519


   Thx


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan closed issue #2294: idle_timeout will be lost when set to 0 in upstream

Posted by GitBox <gi...@apache.org>.
juzhiyuan closed issue #2294:
URL: https://github.com/apache/apisix-dashboard/issues/2294


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org