You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/25 04:24:17 UTC
[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #262: feat: ApisixRoute v2alpha1
gxthrj commented on a change in pull request #262:
URL: https://github.com/apache/apisix-ingress-controller/pull/262#discussion_r582535841
##########
File path: pkg/ingress/controller/controller.go
##########
@@ -338,17 +340,6 @@ type Api6Controller struct {
Stop <-chan struct{}
}
-func (api6 *Api6Controller) ApisixRoute(controller *Controller) {
Review comment:
We discussed earlier that we should keep the v1 version for a while, declare in the document "deprecated", and delete the logic of v1 in version 1.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org