[GitHub] [arrow] projjal commented on a diff in pull request #13446: ARROW-16917: [C++][Gandiva] Add a Secondary Cache to cache gandiva object code

[GitBox <gi...@apache.org>]

projjal commented on code in PR #13446:
URL: https://github.com/apache/arrow/pull/13446#discussion_r919624157


##########
cpp/src/gandiva/filter.cc:
##########
@@ -37,8 +37,15 @@ Filter::Filter(std::unique_ptr<LLVMGenerator> llvm_generator, SchemaPtr schema,
 
 Filter::~Filter() {}
 
+Status Filter::Make(SchemaPtr schema, ConditionPtr condition,
+                    std::shared_ptr<Configuration> config,
+                    std::shared_ptr<Filter>* filter) {
+  return Make(schema, condition, config, nullptr, filter);
+}
+
 Status Filter::Make(SchemaPtr schema, ConditionPtr condition,
                     std::shared_ptr<Configuration> configuration,
+                    std::shared_ptr<SecondaryCacheInterface> sec_cache,

Review Comment:
   This isn't getting used



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org