You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by bl...@apache.org on 2013/06/21 01:50:42 UTC

svn propchange: r1495209 - svn:log

Author: blair
Revision: 1495209
Modified property: svn:log

Modified: svn:log at Thu Jun 20 23:50:42 2013
------------------------------------------------------------------------------
--- svn:log (original)
+++ svn:log Thu Jun 20 23:50:42 2013
@@ -2,6 +2,16 @@ Make the hash function used by the FSFS 
 platform-independent. That should help us reproducing issues
 detected on "exotic" platforms.
 
+This illustrates what happened before the patch:
+
+  char c = 99;
+  unsigned hash = 0;
+  hash |= c << 8; /* c << 8 is often 0, actually it's undefined */
+ 
+On a more general note, you don't want to make it easy for parts of
+the input to cancel each other out.  So, adding (potentially) negative
+values is a bad thing (strategically).
+
 * subversion/libsvn_fs_fs/tree.c
   (cache_lookup): normalize chunked calculation to big endian