[jira] [Commented] (LOG4J2-1071) Allow for bufferSize=0 in SMTP appender

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LOG4J2-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16105784#comment-16105784 ] 

ASF subversion and git services commented on LOG4J2-1071:
---------------------------------------------------------

Commit bc3e711d3e68deb0ebf2a83ea3cdf6929ee68217 in logging-log4j2's branch refs/heads/master from [~garydgregory]
[ https://git-wip-us.apache.org/repos/asf?p=logging-log4j2.git;h=bc3e711 ]

[LOG4J2-1071] Allow for bufferSize=0 in SMTP appender. Add tests.

> Allow for bufferSize=0 in SMTP appender
> ---------------------------------------
>
>                 Key: LOG4J2-1071
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-1071
>             Project: Log4j 2
>          Issue Type: Improvement
>          Components: Appenders
>    Affects Versions: 2.3
>            Reporter: Benjamin Jaton
>            Priority: Minor
>         Attachments: CyclicBuffer.patch
>
>
> From the doc:
> "The number of logging events delivered in this e-mail depend on the value of BufferSize option. The SMTPAppender keeps only the last BufferSize logging events in its cyclic buffer. This keeps memory requirements at a reasonable level while still delivering useful application context. All events in the buffer are included in the email. The buffer will contain the most recent events of level TRACE to WARN preceding the event that triggered the email."
> https://logging.apache.org/log4j/2.x/manual/appenders.html#SMTPAppender
> The bufferSize is the number of messages preceding the message that triggered the event. They might be completely unrelated. One may not want to include them in the email at all, so having a bufferSize of 0 makes sense.
> This is however disallowed in the code:
> Caused by: java.lang.IllegalArgumentException: The maxSize argument (0) is not a positive integer.
> 	at org.apache.logging.log4j.core.util.CyclicBuffer.<init>(CyclicBuffer.java:41)
> 	at org.apache.logging.log4j.core.net.SmtpManager.<init>(SmtpManager.java:70)
> 	at org.apache.logging.log4j.core.net.SmtpManager$SMTPManagerFactory.createManager(SmtpManager.java:338)
> 	at org.apache.logging.log4j.core.net.SmtpManager$SMTPManagerFactory.createManager(SmtpManager.java:299)
> 	at org.apache.logging.log4j.core.appender.AbstractManager.getManager(AbstractManager.java:71)
> 	at org.apache.logging.log4j.core.net.SmtpManager.getSMTPManager(SmtpManager.java:124)
> 	at org.apache.logging.log4j.core.appender.SmtpAppender.createAppender(SmtpAppender.java:142)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)