[GitHub] spark pull request #15009: [SPARK-17443][SPARK-11035] Stop Spark Application...

[vanzin <gi...@git.apache.org>]

Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15009#discussion_r114173041
  
    --- Diff: resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnClusterSuite.scala ---
    @@ -162,29 +172,10 @@ class YarnClusterSuite extends BaseYarnClusterSuite {
       }
     
       test("monitor app using launcher library") {
    -    val env = new JHashMap[String, String]()
    -    env.put("YARN_CONF_DIR", hadoopConfDir.getAbsolutePath())
    -
    -    val propsFile = createConfFile()
    -    val handle = new SparkLauncher(env)
    -      .setSparkHome(sys.props("spark.test.home"))
    -      .setConf("spark.ui.enabled", "false")
    -      .setPropertiesFile(propsFile)
    -      .setMaster("yarn")
    -      .setDeployMode("client")
    -      .setAppResource(SparkLauncher.NO_RESOURCE)
    -      .setMainClass(mainClassName(YarnLauncherTestApp.getClass))
    -      .startApplication()
    -
    +    var handle : SparkAppHandle = null
         try {
    -      eventually(timeout(30 seconds), interval(100 millis)) {
    -        handle.getState() should be (SparkAppHandle.State.RUNNING)
    -      }
    -
    -      handle.getAppId() should not be (null)
    -      handle.getAppId() should startWith ("application_")
    +      handle = launchSparkAppWithConf(false, false, "client")
    --- End diff --
    
    You need to initialize the handle outside the `try`, otherwise you will get an NPE in the `finally` block.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org