You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2015/08/06 17:53:24 UTC

[Bug 58219] New: Refactoer

https://bz.apache.org/bugzilla/show_bug.cgi?id=58219

            Bug ID: 58219
           Summary: Refactoer
           Product: POI
           Version: unspecified
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: trivial
          Priority: P2
         Component: XSSF
          Assignee: dev@poi.apache.org
          Reporter: dtn-asfbugs@corefiling.co.uk

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 58219] Refactor XSSFSheet to allow callers to avoid DOM parse of big sheets

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58219

David North <dt...@corefiling.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |---
             Status|RESOLVED                    |REOPENED

--- Comment #8 from David North <dt...@corefiling.co.uk> ---
Sorry, yes, I was leaving out of the docs until we'd discussed. Re-opening to
track documentation.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 58219] Refactor XSSFSheet to allow callers to avoid DOM parse of big sheets

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58219

David North <dt...@corefiling.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from David North <dt...@corefiling.co.uk> ---
Thanks for the review, Nick. Calling this fixed now I've added the example.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 58219] Refactor XSSFSheet to allow callers to avoid DOM parse of big sheets

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58219

David North <dt...@corefiling.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Refactoer                   |Refactor XSSFSheet to allow
                   |                            |callers to avoid DOM parse
                   |                            |of big sheets

--- Comment #1 from David North <dt...@corefiling.co.uk> ---
Our application implements a hybrid approach to XSSF parsing, where we exclude
certain large sheets from DOM parsing and run them through a streaming parse
later.

I don't think our local changes make sense to merge into POI itself, but if
XSSFSheet were refactored slightly, it would allow us to do our changes by
subclassing, avoiding the need to modify POI itself and run with a patched
version.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 58219] Refactor XSSFSheet to allow callers to avoid DOM parse of big sheets

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58219

David North <dt...@corefiling.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #9 from David North <dt...@corefiling.co.uk> ---
... and documented on the website, svn r1695862.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 58219] Refactor XSSFSheet to allow callers to avoid DOM parse of big sheets

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58219

--- Comment #5 from David North <dt...@corefiling.co.uk> ---
Further tidy up in r1694537

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 58219] Refactor XSSFSheet to allow callers to avoid DOM parse of big sheets

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58219

Nick Burch <ap...@gagravarr.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO

--- Comment #3 from Nick Burch <ap...@gagravarr.org> ---
Any chance you could put a stripped-down version of your subclass into
examples, to show users how they might take that approach?

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 58219] Refactor XSSFSheet to allow callers to avoid DOM parse of big sheets

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58219

--- Comment #7 from Nick Burch <ap...@gagravarr.org> ---
Any chance you could put a mention about this somewhere in the spreadsheet
documentation on the site?

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 58219] Refactor XSSFSheet to allow callers to avoid DOM parse of big sheets

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58219

Dominik Stadler <do...@gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|trivial                     |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 58219] Refactor XSSFSheet to allow callers to avoid DOM parse of big sheets

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58219

--- Comment #2 from David North <dt...@corefiling.co.uk> ---
Made my proposed refactoring in r1694531. I'll leave this open for a few days
in case any other devs want to object/discuss.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 58219] Refactor XSSFSheet to allow callers to avoid DOM parse of big sheets

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58219

--- Comment #4 from David North <dt...@corefiling.co.uk> ---
Added example in r1694536

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org