[GitHub] [airflow] RosterIn commented on a change in pull request #5103: [AIRFLOW-XXX] Fix docstrings for CassandraToGoogleCloudStorageOperator

[GitBox <gi...@apache.org>]

RosterIn commented on a change in pull request #5103: [AIRFLOW-XXX] Fix docstrings for CassandraToGoogleCloudStorageOperator
URL: https://github.com/apache/airflow/pull/5103#discussion_r275374170
 
 

 ##########
 File path: airflow/contrib/operators/cassandra_to_gcs.py
 ##########
 @@ -41,6 +41,35 @@ class CassandraToGoogleCloudStorageOperator(BaseOperator):
     Copy data from Cassandra to Google cloud storage in JSON format
 
     Note: Arrays of arrays are not supported.
+
+    :param cql: The CQL to execute on the Cassandra table.
+    :type cql: str
+    :param bucket: The bucket to upload to.
+    :type bucket: str
+    :param filename: The filename to use as the object name when uploading
+        to Google cloud storage. A {} should be specified in the filename
+        to allow the operator to inject file numbers in cases where the
+        file is split due to size.
+    :type filename: str
+    :param schema_filename: If set, the filename to use as the object name
+        when uploading a .json file containing the BigQuery schema fields
+        for the table that was dumped from MySQL.
+    :type schema_filename: str
+    :param approx_max_file_size_bytes: This operator supports the ability
+        to split large table dumps into multiple files (see notes in the
+        filenamed param docs above). Google cloud storage allows for files
+        to be a maximum of 4GB. This param allows developers to specify the
 
 Review comment:
   As mentioned in another PR.
   This is wrong. The limit is not 4GB it's 5GB:
   https://cloud.google.com/storage/quotas
   "There is a maximum size limit of 5 TB for individual objects stored in Cloud Storage."
   I think in general It's best not to mention it at all. The limits can change at will. Airflow can't keep track of all size changes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services