You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@linkis.apache.org by GitBox <gi...@apache.org> on 2022/02/10 09:04:59 UTC
[GitHub] [incubator-linkis] legendtkl opened a new pull request #1425: [Feature] unify the log config file of ec to log4j2.xml
legendtkl opened a new pull request #1425:
URL: https://github.com/apache/incubator-linkis/pull/1425
ref: https://github.com/apache/incubator-linkis/issues/1424
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org
[GitHub] [incubator-linkis] legendtkl commented on a change in pull request #1425: [Feature] unify the log config file of ec to log4j2.xml
Posted by GitBox <gi...@apache.org>.
legendtkl commented on a change in pull request #1425:
URL: https://github.com/apache/incubator-linkis/pull/1425#discussion_r803447084
##########
File path: linkis-engineconn-plugins/engineconn-plugins/hive/src/main/assembly/distribution.xml
##########
@@ -230,8 +230,7 @@
<fileSet>
<directory>${basedir}/src/main/resources</directory>
<includes>
- <include>linkis-engineconn.properties</include>
- <include>log4j2-engineconn.xml</include>
+ <include>*</include>
Review comment:
unify code style for all the distribution scripts of ecs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org
[GitHub] [incubator-linkis] legendtkl commented on pull request #1425: [Feature] unify the log config file of ec to log4j2.xml
Posted by GitBox <gi...@apache.org>.
legendtkl commented on pull request #1425:
URL: https://github.com/apache/incubator-linkis/pull/1425#issuecomment-1034668182
Hi, @peacewong , would help review this pr?
Thanks, kelu.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org
[GitHub] [incubator-linkis] legendtkl commented on a change in pull request #1425: [Feature] unify the log config file of ec to log4j2.xml
Posted by GitBox <gi...@apache.org>.
legendtkl commented on a change in pull request #1425:
URL: https://github.com/apache/incubator-linkis/pull/1425#discussion_r803447084
##########
File path: linkis-engineconn-plugins/engineconn-plugins/hive/src/main/assembly/distribution.xml
##########
@@ -230,8 +230,7 @@
<fileSet>
<directory>${basedir}/src/main/resources</directory>
<includes>
- <include>linkis-engineconn.properties</include>
- <include>log4j2-engineconn.xml</include>
+ <include>*</include>
Review comment:
为了和其他 ec 的 assembly 脚本写法保持一致
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org
[GitHub] [incubator-linkis] peacewong merged pull request #1425: [Feature] unify the log config file of ec to log4j2.xml
Posted by GitBox <gi...@apache.org>.
peacewong merged pull request #1425:
URL: https://github.com/apache/incubator-linkis/pull/1425
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org