[jira] [Commented] (LOG4PHP-147) Bugs during HipHop build

["Karan Jain (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LOG4PHP-147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13097057#comment-13097057 ] 

Karan Jain commented on LOG4PHP-147:
------------------------------------

Hi Ivan,

I did a build after the above mentioned fixes. Everything worked fine except this -

>> "UnknownFunction": 
["log4php/Logger.php",25,0,25,50] ,"d":"spl_autoload_register(array('Logger', 'autoload'))" 

I cross checked and found that HipHop does not support this function as of now. So, I decided to see if HipHop allows __autoload function since it would be easy to replace the spl_autoload_register call here with the __autoload function provided it is making only single call for now. Though HipHop allowed compilation for __autoload but it didn't bring into effect the execution of __autoload i.e. code wriiten in __autoload didn't execute. So, I believe that HipHop does not support this function.

In Logger.php, I believe the only job autoload function is doing is including the php file whenever it is being called via new Classname. Since I want the work to be done via HipHop and owing to above issues, will it be fine if I simply include all the required files for once at the top and remove the call to spl_autoload_register? I know this would affect the performance but this is the best way I could think of.

Please suggest.

Thanks,
Karan

> Bugs during HipHop build
> ------------------------
>
>                 Key: LOG4PHP-147
>                 URL: https://issues.apache.org/jira/browse/LOG4PHP-147
>             Project: Log4php
>          Issue Type: Bug
>         Environment: Linux
>            Reporter: Hitesh Kumar
>            Assignee: Ivan Habunek
>              Labels: build
>
> The following log4php errors show up during the HipHop build:
> "UnknownClass":[
> 	{"c1":
> 		["\/var\/lib\/tomcat6\/webapps\/hudson\/jobs\/Rontgen\/workspace\/lib\/log4php\/appenders\/LoggerAppenderMongoDB.php",119,23,119,76] ,"d":"new Mongo(sprintf('%s:%d', $this->host, $this->port))"
> 	} ,
> 	{"c1":
> 		["\/var\/lib\/tomcat6\/webapps\/hudson\/jobs\/Rontgen\/workspace\/lib\/log4php\/appenders\/LoggerAppenderMongoDB.php",160,19,160,63] ,"d":"new MongoDate($timestampSec, $timestampUsec)"
> 	} ,
> 	{"c1":
> 		["\/var\/lib\/tomcat6\/webapps\/hudson\/jobs\/Rontgen\/workspace\/lib\/log4php\/helpers\/LoggerPatternParser.php",309,12,309,104] ,"d":"new LoggerUserFieldPatternConverter($this->formattingInfo, (string)ord($cNext) - 48)"
> 	} 
> ]
> "UnknownObjectMethod":[
> 	{"c1":
> 		["\/var\/lib\/tomcat6\/webapps\/hudson\/jobs\/Rontgen\/workspace\/lib\/log4php\/appenders\/LoggerAppenderMongoDB.php",120,26,120,57] ,"d":"$this->connection->selectDB($this->databaseName)"
> 	} ,
> 	{"c1":
> 		["\/var\/lib\/tomcat6\/webapps\/hudson\/jobs\/Rontgen\/workspace\/lib\/log4php\/appenders\/LoggerAppenderMongoDB.php",122,69,122,69] ,"d":"$db->authenticate($this->userName, $this->password)"
> 	} ,
> 	{"c1":
> 		["\/var\/lib\/tomcat6\/webapps\/hudson\/jobs\/Rontgen\/workspace\/lib\/log4php\/appenders\/LoggerAppenderMongoDB.php",128,67,128,67] ,"d":"$db->selectCollection($this->collectionName)"
> 	} ,
> 	{"c1":
> 		["\/var\/lib\/tomcat6\/webapps\/hudson\/jobs\/Rontgen\/workspace\/lib\/log4php\/appenders\/LoggerAppenderMongoDB.php",145,20,145,39] ,"d":"$this->collection->insert($document)"
> 	} ,
> 	{"c1":
> 		["\/var\/lib\/tomcat6\/webapps\/hudson\/jobs\/Rontgen\/workspace\/lib\/log4php\/appenders\/LoggerAppenderMongoDB.php",198,61,198,61] ,"d":"$ex->getPrevious()"
> 	} ,
> 	{"c1":
> 		["\/var\/lib\/tomcat6\/webapps\/hudson\/jobs\/Rontgen\/workspace\/lib\/log4php\/appenders\/LoggerAppenderMongoDB.php",199,71,199,71] ,"d":"$ex->getPrevious()"
> 	} ,
> 	{"c1":
> 		["\/var\/lib\/tomcat6\/webapps\/hudson\/jobs\/Rontgen\/workspace\/lib\/log4php\/renderers\/LoggerRendererException.php",34,59,34,59] ,"d":"$o->getPrevious()"
> 	} ,
> 	{"c1":
> 		["\/var\/lib\/tomcat6\/webapps\/hudson\/jobs\/Rontgen\/workspace\/lib\/log4php\/renderers\/LoggerRendererException.php",35,67,35,67] ,"d":"$o->getPrevious()"
> 	} 
> ]
> "UnknownFunction":[
> 	{"c1":
> 		["\/var\/lib\/tomcat6\/webapps\/hudson\/jobs\/Rontgen\/workspace\/lib\/log4php\/Logger.php",25,0,25,50] ,"d":"spl_autoload_register(array('Logger', 'autoload'))"
> 	} ,
> 	{"c1":
> 		["\/var\/lib\/tomcat6\/webapps\/hudson\/jobs\/Rontgen\/workspace\/lib\/log4php\/appenders\/LoggerAppenderAdodb.php",122,15,122,44] ,"d":"adonewconnection($this->type)"
> 	} ,
> 	{"c1":
> 		["\/var\/lib\/tomcat6\/webapps\/hudson\/jobs\/Rontgen\/workspace\/lib\/log4php\/appenders\/LoggerAppenderSocket.php",188,2,188,17] ,"d":"parent::reset()"
> 	} 
> ] 
> "RequiredAfterOptionalParam":[
> 	{"c1":
> 		["\/var\/lib\/tomcat6\/webapps\/hudson\/jobs\/Rontgen\/workspace\/lib\/log4php\/configurators\/LoggerConfiguratorXml.php",138,30,138,68] ,"d":"LoggerHierarchy $repository"
> 	}
> ]
> "UseVoidReturn":[
> 	{"c1":
> 		["\/var\/lib\/tomcat6\/webapps\/hudson\/jobs\/Rontgen\/workspace\/lib\/log4php\/LoggerReflectionUtils.php",52,54,52,54] ,"d":"$pSetter->setProperties($properties, $prefix)"
> 	}
> ] 
> "UseUndeclaredConstant":[
> 	{"c1":
> 		["\/var\/lib\/tomcat6\/webapps\/hudson\/jobs\/Rontgen\/workspace\/lib\/log4php\/appenders\/LoggerAppenderAdodb.php",22,13,22,22] ,"d":"ADODB_DIR"
> 	}
> ]
> Please suggest a way to fix them, or if it's not fixable in the released version, please fix them in the to-be-released version.
> Thanks

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira