You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "agavra (via GitHub)" <gi...@apache.org> on 2024/12/20 18:24:28 UTC
[PR] KAFKA-18326: fix merge iterator with cache tombstones [kafka]
agavra opened a new pull request, #18287:
URL: https://github.com/apache/kafka/pull/18287
See https://issues.apache.org/jira/browse/KAFKA-18326 for more information. The main bug here is that in the old implementation, deleted cache entries would be skipped so long as they didn't equal the next store key, which resulted in potentially skipping tombstones for future keys in the store.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18326: fix merge iterator with cache tombstones [kafka]
Posted by "ableegoldman (via GitHub)" <gi...@apache.org>.
ableegoldman commented on PR #18287:
URL: https://github.com/apache/kafka/pull/18287#issuecomment-2566682101
I assume we're going to cherrypick this back to 4.0, but what about earlier? I'm guessing at least 3.9 makes sense as well since some people may not be able to upgrade to 4.0 as a major version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18326: fix merge iterator with cache tombstones [kafka]
Posted by "ableegoldman (via GitHub)" <gi...@apache.org>.
ableegoldman commented on PR #18287:
URL: https://github.com/apache/kafka/pull/18287#issuecomment-2576891423
Test failures are unrelated. Merged to trunk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18326: fix merge iterator with cache tombstones [kafka]
Posted by "agavra (via GitHub)" <gi...@apache.org>.
agavra commented on PR #18287:
URL: https://github.com/apache/kafka/pull/18287#issuecomment-2566790126
@ableegoldman I imagine there wouldn't be any merge conflicts, so 3.9 definitely makes sense and possibly 3.8 if it isn't too much
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18326: fix merge iterator with cache tombstones [kafka]
Posted by "ableegoldman (via GitHub)" <gi...@apache.org>.
ableegoldman merged PR #18287:
URL: https://github.com/apache/kafka/pull/18287
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18326: fix merge iterator with cache tombstones [kafka]
Posted by "ableegoldman (via GitHub)" <gi...@apache.org>.
ableegoldman commented on PR #18287:
URL: https://github.com/apache/kafka/pull/18287#issuecomment-2576907957
cherry-picked to 4.0, 3.9, and 3.8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org