You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "raghavagrawal (via GitHub)" <gi...@apache.org> on 2024/12/23 08:59:28 UTC
[PR] Add support for KLL sketch aggregation in minion jobs [pinot]
raghavagrawal opened a new pull request, #14702:
URL: https://github.com/apache/pinot/pull/14702
## CR Description
1. Add support for KLL sketch aggregation in minion jobs
2. Added new aggregator class PercentileKLLSketchAggregator.java for minion value aggregator.
## Issue details
https://github.com/apache/pinot/issues/14548
## Testing details
Manual testing done by creating new table in local setup: https://docs.google.com/document/d/1N6F9zF39YSGvGPENzhLwxpJQq54WpKn1hSsDnYU-jPo/edit?usp=sharing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Add support for KLL sketch aggregation in minion jobs [pinot]
Posted by "yashmayya (via GitHub)" <gi...@apache.org>.
yashmayya commented on code in PR #14702:
URL: https://github.com/apache/pinot/pull/14702#discussion_r1895656731
##########
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/aggregator/PercentileKLLSketchAggregator.java:
##########
@@ -0,0 +1,53 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.core.segment.processing.aggregator;
+
+import org.apache.datasketches.common.SketchesArgumentException;
+import org.apache.datasketches.kll.KllDoublesSketch;
+import org.apache.pinot.core.common.ObjectSerDeUtils;
+
+/**
+ * Class to merge KLL doubles sketch for minion merge/rollup tasks.
+ */
+public class PercentileKLLSketchAggregator implements ValueAggregator {
+
+ protected static final int DEFAULT_K_VALUE = 200;
+
+ /**
+ * Given two kll doubles sketches, return the aggregated kll doubles sketches
+ * @return aggregated sketch given two kll doubles sketches
+ */
+ @Override
+ public Object aggregate(Object value1, Object value2) {
Review Comment:
This interface method was updated in https://github.com/apache/pinot/pull/14373. You'll need to rebase your changes (check the compilation failures in CI - https://github.com/apache/pinot/actions/runs/12464118111?pr=14702)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Add support for KLL sketch aggregation in minion jobs [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on code in PR #14702:
URL: https://github.com/apache/pinot/pull/14702#discussion_r1915935274
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/Constants.java:
##########
@@ -33,4 +33,5 @@ private Constants() {
public static final String THETA_TUPLE_SKETCH_SAMPLING_PROBABILITY = "samplingProbability";
public static final String PERCENTILETDIGEST_COMPRESSION_FACTOR_KEY = "compressionFactor";
public static final String SUMPRECISION_PRECISION_KEY = "precision";
+ public static final String KLL_DOUBLE_SKETCH_K = "K";
Review Comment:
Do we want to make this capital `K`? Also calling it `DOUBLE_SKETCH_K` is a little bit confusing because it is actually an `int`.
If we follow the same format as `HLL`, it should be `KLL_SKETCH_K_KEY = "k"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Add support for KLL sketch aggregation in minion jobs [pinot]
Posted by "raghavagrawal (via GitHub)" <gi...@apache.org>.
raghavagrawal commented on code in PR #14702:
URL: https://github.com/apache/pinot/pull/14702#discussion_r1913375083
##########
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/aggregator/PercentileKLLSketchAggregator.java:
##########
@@ -0,0 +1,70 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.core.segment.processing.aggregator;
+
+import java.util.Map;
+import org.apache.datasketches.common.SketchesArgumentException;
+import org.apache.datasketches.kll.KllDoublesSketch;
+import org.apache.pinot.core.common.ObjectSerDeUtils;
+import org.apache.pinot.segment.spi.Constants;
+import org.apache.pinot.spi.utils.CommonConstants;
+
+
+/**
+ * Class to merge KLL doubles sketch for minion merge/rollup tasks.
+ */
+public class PercentileKLLSketchAggregator implements ValueAggregator {
+
+ protected static final int DEFAULT_K_VALUE = 200;
+
+ /**
+ * Given two kll doubles sketches, return the aggregated kll doubles sketches
+ * @return aggregated sketch given two kll doubles sketches
+ */
+ @Override
+ public Object aggregate(Object value1, Object value2, Map<String, String> functionParameters) {
+ try {
+ String kValueParam = functionParameters.get(Constants.KLL_DOUBLE_SKETCH_K_VALUE);
+
+ int sketchKValue;
+
+ // Check if nominal entries values match
+ if (kValueParam != null) {
+ sketchKValue = Integer.parseInt(kValueParam);
+ } else {
+ // If the functionParameters don't have an explicit K value set,
+ // use the default value for K
+ sketchKValue = CommonConstants.Helix.DEFAULT_KLL_SKETCH_K;
+ }
+
+ KllDoublesSketch first = ObjectSerDeUtils.KLL_SKETCH_SER_DE.deserialize((byte[]) value1);
+ KllDoublesSketch second = ObjectSerDeUtils.KLL_SKETCH_SER_DE.deserialize((byte[]) value2);
+ KllDoublesSketch union = KllDoublesSketch.newHeapInstance(sketchKValue);
+ if (first != null) {
+ union.merge(first);
+ }
+ if (second != null) {
+ union.merge(second);
+ }
Review Comment:
It can't be null, removing this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Add support for KLL sketch aggregation in minion jobs [pinot]
Posted by "yashmayya (via GitHub)" <gi...@apache.org>.
yashmayya commented on code in PR #14702:
URL: https://github.com/apache/pinot/pull/14702#discussion_r1900573674
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/Constants.java:
##########
@@ -32,4 +32,5 @@ private Constants() {
public static final String THETA_TUPLE_SKETCH_NOMINAL_ENTRIES = "nominalEntries";
public static final String PERCENTILETDIGEST_COMPRESSION_FACTOR_KEY = "compressionFactor";
public static final String SUMPRECISION_PRECISION_KEY = "precision";
+ public static final String KLL_DOUBLE_SKETCH_K_VALUE = "kValue";
Review Comment:
Maybe we can simply call this `K` as that's what DataSketches seems to use - https://datasketches.apache.org/docs/KLL/KLLAccuracyAndSize.html#:~:?
##########
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/aggregator/PercentileKLLSketchAggregator.java:
##########
@@ -0,0 +1,70 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.core.segment.processing.aggregator;
+
+import java.util.Map;
+import org.apache.datasketches.common.SketchesArgumentException;
+import org.apache.datasketches.kll.KllDoublesSketch;
+import org.apache.pinot.core.common.ObjectSerDeUtils;
+import org.apache.pinot.segment.spi.Constants;
+import org.apache.pinot.spi.utils.CommonConstants;
+
+
+/**
+ * Class to merge KLL doubles sketch for minion merge/rollup tasks.
+ */
+public class PercentileKLLSketchAggregator implements ValueAggregator {
+
+ protected static final int DEFAULT_K_VALUE = 200;
+
+ /**
+ * Given two kll doubles sketches, return the aggregated kll doubles sketches
+ * @return aggregated sketch given two kll doubles sketches
+ */
+ @Override
+ public Object aggregate(Object value1, Object value2, Map<String, String> functionParameters) {
+ try {
+ String kValueParam = functionParameters.get(Constants.KLL_DOUBLE_SKETCH_K_VALUE);
+
+ int sketchKValue;
+
+ // Check if nominal entries values match
+ if (kValueParam != null) {
+ sketchKValue = Integer.parseInt(kValueParam);
+ } else {
+ // If the functionParameters don't have an explicit K value set,
+ // use the default value for K
Review Comment:
nit: can be a single line comment, the max line length is 120.
##########
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/aggregator/PercentileKLLSketchAggregator.java:
##########
@@ -0,0 +1,70 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.core.segment.processing.aggregator;
+
+import java.util.Map;
+import org.apache.datasketches.common.SketchesArgumentException;
+import org.apache.datasketches.kll.KllDoublesSketch;
+import org.apache.pinot.core.common.ObjectSerDeUtils;
+import org.apache.pinot.segment.spi.Constants;
+import org.apache.pinot.spi.utils.CommonConstants;
+
+
+/**
+ * Class to merge KLL doubles sketch for minion merge/rollup tasks.
+ */
+public class PercentileKLLSketchAggregator implements ValueAggregator {
+
+ protected static final int DEFAULT_K_VALUE = 200;
Review Comment:
Can be removed here as you've added `DEFAULT_KLL_SKETCH_K` to the Helix common constants.
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -129,6 +129,10 @@ public static class Helix {
public static final int DEFAULT_CPC_SKETCH_LGK = 12;
public static final int DEFAULT_ULTRALOGLOG_P = 12;
+ // K is set to 200, for tradeoffs see datasketches library documentation:
+ // https://datasketches.apache.org/docs/KLL/KLLAccuracyAndSize.html#:~:
+ public static final int DEFAULT_KLL_SKETCH_K = 200;
+
Review Comment:
Can you also update `PercentileKLLAggregationFunction` to use this default and remove the duplicate default from there?
##########
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/aggregator/PercentileKLLSketchAggregator.java:
##########
@@ -0,0 +1,70 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.core.segment.processing.aggregator;
+
+import java.util.Map;
+import org.apache.datasketches.common.SketchesArgumentException;
+import org.apache.datasketches.kll.KllDoublesSketch;
+import org.apache.pinot.core.common.ObjectSerDeUtils;
+import org.apache.pinot.segment.spi.Constants;
+import org.apache.pinot.spi.utils.CommonConstants;
+
+
+/**
+ * Class to merge KLL doubles sketch for minion merge/rollup tasks.
+ */
+public class PercentileKLLSketchAggregator implements ValueAggregator {
+
+ protected static final int DEFAULT_K_VALUE = 200;
+
+ /**
+ * Given two kll doubles sketches, return the aggregated kll doubles sketches
+ * @return aggregated sketch given two kll doubles sketches
+ */
+ @Override
+ public Object aggregate(Object value1, Object value2, Map<String, String> functionParameters) {
+ try {
+ String kValueParam = functionParameters.get(Constants.KLL_DOUBLE_SKETCH_K_VALUE);
+
+ int sketchKValue;
+
+ // Check if nominal entries values match
+ if (kValueParam != null) {
+ sketchKValue = Integer.parseInt(kValueParam);
+ } else {
+ // If the functionParameters don't have an explicit K value set,
+ // use the default value for K
+ sketchKValue = CommonConstants.Helix.DEFAULT_KLL_SKETCH_K;
+ }
+
+ KllDoublesSketch first = ObjectSerDeUtils.KLL_SKETCH_SER_DE.deserialize((byte[]) value1);
+ KllDoublesSketch second = ObjectSerDeUtils.KLL_SKETCH_SER_DE.deserialize((byte[]) value2);
+ KllDoublesSketch union = KllDoublesSketch.newHeapInstance(sketchKValue);
+ if (first != null) {
+ union.merge(first);
+ }
+ if (second != null) {
+ union.merge(second);
+ }
Review Comment:
When would these values be `null`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Add support for KLL sketch aggregation in minion jobs [pinot]
Posted by "yashmayya (via GitHub)" <gi...@apache.org>.
yashmayya merged PR #14702:
URL: https://github.com/apache/pinot/pull/14702
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Add support for KLL sketch aggregation in minion jobs [pinot]
Posted by "raghavagrawal (via GitHub)" <gi...@apache.org>.
raghavagrawal commented on code in PR #14702:
URL: https://github.com/apache/pinot/pull/14702#discussion_r1899086300
##########
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/aggregator/PercentileKLLSketchAggregator.java:
##########
@@ -0,0 +1,53 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.core.segment.processing.aggregator;
+
+import org.apache.datasketches.common.SketchesArgumentException;
+import org.apache.datasketches.kll.KllDoublesSketch;
+import org.apache.pinot.core.common.ObjectSerDeUtils;
+
+/**
+ * Class to merge KLL doubles sketch for minion merge/rollup tasks.
+ */
+public class PercentileKLLSketchAggregator implements ValueAggregator {
+
+ protected static final int DEFAULT_K_VALUE = 200;
+
+ /**
+ * Given two kll doubles sketches, return the aggregated kll doubles sketches
+ * @return aggregated sketch given two kll doubles sketches
+ */
+ @Override
+ public Object aggregate(Object value1, Object value2) {
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Add support for KLL sketch aggregation in minion jobs [pinot]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #14702:
URL: https://github.com/apache/pinot/pull/14702#issuecomment-2565129164
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 0.00%. Comparing base [(`59551e4`)](https://app.codecov.io/gh/apache/pinot/commit/59551e45224f1535c4863fd577622b37366ccc97?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`baf6a61`)](https://app.codecov.io/gh/apache/pinot/commit/baf6a6155ac1807dfab0eb1ba31703c6b0cc2e45?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 1517 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (59551e4) and HEAD (baf6a61). Click for more details.
>
> <details><summary>HEAD has 53 uploads less than BASE</summary>
>
>| Flag | BASE (59551e4) | HEAD (baf6a61) |
>|------|------|------|
>|integration|7|1|
>|integration2|3|1|
>|temurin|12|1|
>|java-21|7|1|
>|skip-bytebuffers-true|3|1|
>|skip-bytebuffers-false|7|0|
>|unittests|5|0|
>|unittests1|2|0|
>|java-11|5|0|
>|unittests2|3|0|
>|integration1|2|0|
>|custom-integration1|2|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #14702 +/- ##
=============================================
- Coverage 61.75% 0.00% -61.76%
=============================================
Files 2436 3 -2433
Lines 133233 6 -133227
Branches 20636 0 -20636
=============================================
- Hits 82274 0 -82274
+ Misses 44911 6 -44905
+ Partials 6048 0 -6048
```
| [Flag](https://app.codecov.io/gh/apache/pinot/pull/14702/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/14702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration](https://app.codecov.io/gh/apache/pinot/pull/14702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (-0.01%)` | :arrow_down: |
| [integration1](https://app.codecov.io/gh/apache/pinot/pull/14702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration2](https://app.codecov.io/gh/apache/pinot/pull/14702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | |
| [java-11](https://app.codecov.io/gh/apache/pinot/pull/14702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-21](https://app.codecov.io/gh/apache/pinot/pull/14702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (-61.63%)` | :arrow_down: |
| [skip-bytebuffers-false](https://app.codecov.io/gh/apache/pinot/pull/14702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [skip-bytebuffers-true](https://app.codecov.io/gh/apache/pinot/pull/14702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (-27.73%)` | :arrow_down: |
| [temurin](https://app.codecov.io/gh/apache/pinot/pull/14702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (-61.76%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pinot/pull/14702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unittests1](https://app.codecov.io/gh/apache/pinot/pull/14702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unittests2](https://app.codecov.io/gh/apache/pinot/pull/14702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/pinot/pull/14702?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Add support for KLL sketch aggregation in minion jobs [pinot]
Posted by "raghavagrawal (via GitHub)" <gi...@apache.org>.
raghavagrawal commented on code in PR #14702:
URL: https://github.com/apache/pinot/pull/14702#discussion_r1916674053
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/Constants.java:
##########
@@ -33,4 +33,5 @@ private Constants() {
public static final String THETA_TUPLE_SKETCH_SAMPLING_PROBABILITY = "samplingProbability";
public static final String PERCENTILETDIGEST_COMPRESSION_FACTOR_KEY = "compressionFactor";
public static final String SUMPRECISION_PRECISION_KEY = "precision";
+ public static final String KLL_DOUBLE_SKETCH_K = "K";
Review Comment:
I have tested this by creating a dummy table and ingesting sketch data to trigger minion jobs. The merge is working as expected. I have added details in description.
`K` was chosen to make it consistent with convention on apache docs. Let me know if we need to change this.
https://datasketches.apache.org/docs/KLL/KLLSketch.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Add support for KLL sketch aggregation in minion jobs [pinot]
Posted by "yashmayya (via GitHub)" <gi...@apache.org>.
yashmayya commented on code in PR #14702:
URL: https://github.com/apache/pinot/pull/14702#discussion_r1917563511
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/Constants.java:
##########
@@ -33,4 +33,5 @@ private Constants() {
public static final String THETA_TUPLE_SKETCH_SAMPLING_PROBABILITY = "samplingProbability";
public static final String PERCENTILETDIGEST_COMPRESSION_FACTOR_KEY = "compressionFactor";
public static final String SUMPRECISION_PRECISION_KEY = "precision";
+ public static final String KLL_DOUBLE_SKETCH_K = "K";
Review Comment:
+1, I think we should stick to `K`. Also I think the naming is because we're using the `KllDoublesSketch` implementation of `KllSketch`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org