You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by mg...@apache.org on 2020/10/04 08:15:37 UTC
[hive] branch master updated: HIVE-24178: Add managed location to
SHOW CREATE DATABASE (Miklos Gergely, reviewed by David Mollitor)
This is an automated email from the ASF dual-hosted git repository.
mgergely pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hive.git
The following commit(s) were added to refs/heads/master by this push:
new 0416770 HIVE-24178: Add managed location to SHOW CREATE DATABASE (Miklos Gergely, reviewed by David Mollitor)
0416770 is described below
commit 04167704772828b37ed749e2a098d6d8a6838bf2
Author: Miklos Gergely <mg...@cloudera.com>
AuthorDate: Sun Oct 4 10:15:19 2020 +0200
HIVE-24178: Add managed location to SHOW CREATE DATABASE (Miklos Gergely, reviewed by David Mollitor)
---
.../ddl/database/showcreate/ShowCreateDatabaseOperation.java | 4 ++++
ql/src/test/queries/clientpositive/database_location.q | 2 ++
.../test/results/clientpositive/llap/database_location.q.out | 11 +++++++++++
3 files changed, 17 insertions(+)
diff --git a/ql/src/java/org/apache/hadoop/hive/ql/ddl/database/showcreate/ShowCreateDatabaseOperation.java b/ql/src/java/org/apache/hadoop/hive/ql/ddl/database/showcreate/ShowCreateDatabaseOperation.java
index 1500b8f..dc96a27 100644
--- a/ql/src/java/org/apache/hadoop/hive/ql/ddl/database/showcreate/ShowCreateDatabaseOperation.java
+++ b/ql/src/java/org/apache/hadoop/hive/ql/ddl/database/showcreate/ShowCreateDatabaseOperation.java
@@ -60,6 +60,10 @@ public class ShowCreateDatabaseOperation extends DDLOperation<ShowCreateDatabase
}
createDbCommand.append("LOCATION\n '");
createDbCommand.append(database.getLocationUri()).append("'\n");
+ if (database.getManagedLocationUri() != null) {
+ createDbCommand.append("MANAGEDLOCATION\n '");
+ createDbCommand.append(database.getManagedLocationUri()).append("'\n");
+ }
String propertiesToString = DDLUtils.propertiesToString(database.getParameters(), null);
if (!propertiesToString.isEmpty()) {
createDbCommand.append("WITH DBPROPERTIES (\n");
diff --git a/ql/src/test/queries/clientpositive/database_location.q b/ql/src/test/queries/clientpositive/database_location.q
index af55a80..a08ea7a 100644
--- a/ql/src/test/queries/clientpositive/database_location.q
+++ b/ql/src/test/queries/clientpositive/database_location.q
@@ -28,6 +28,8 @@ CREATE DATABASE db3
LOCATION '${hiveconf:hive.metastore.warehouse.dir}/db3_ext'
MANAGEDLOCATION '${hiveconf:hive.metastore.warehouse.dir}/db3';
+SHOW CREATE DATABASE db3;
+
DESCRIBE DATABASE db3;
EXPLAIN
diff --git a/ql/src/test/results/clientpositive/llap/database_location.q.out b/ql/src/test/results/clientpositive/llap/database_location.q.out
index 801ed41..7969277 100644
--- a/ql/src/test/results/clientpositive/llap/database_location.q.out
+++ b/ql/src/test/results/clientpositive/llap/database_location.q.out
@@ -173,6 +173,17 @@ POSTHOOK: query: CREATE DATABASE db3
POSTHOOK: type: CREATEDATABASE
POSTHOOK: Output: database:db3
#### A masked pattern was here ####
+PREHOOK: query: SHOW CREATE DATABASE db3
+PREHOOK: type: SHOW_CREATEDATABASE
+PREHOOK: Input: database:db3
+POSTHOOK: query: SHOW CREATE DATABASE db3
+POSTHOOK: type: SHOW_CREATEDATABASE
+POSTHOOK: Input: database:db3
+CREATE DATABASE `db3`
+LOCATION
+#### A masked pattern was here ####
+MANAGEDLOCATION
+#### A masked pattern was here ####
PREHOOK: query: DESCRIBE DATABASE db3
PREHOOK: type: DESCDATABASE
PREHOOK: Input: database:db3