You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@roller.apache.org by sn...@apache.org on 2005/12/26 17:46:47 UTC

svn commit: r359076 - /incubator/roller/trunk/src/org/roller/presentation/filters/WeblogPageCacheFilter.java

Author: snoopdave
Date: Mon Dec 26 08:46:44 2005
New Revision: 359076

URL: http://svn.apache.org/viewcvs?rev=359076&view=rev
Log:
Don't cache null or zero length content in page cache (fixes, but does not explain blank page problem)

Modified:
    incubator/roller/trunk/src/org/roller/presentation/filters/WeblogPageCacheFilter.java

Modified: incubator/roller/trunk/src/org/roller/presentation/filters/WeblogPageCacheFilter.java
URL: http://svn.apache.org/viewcvs/incubator/roller/trunk/src/org/roller/presentation/filters/WeblogPageCacheFilter.java?rev=359076&r1=359075&r2=359076&view=diff
==============================================================================
--- incubator/roller/trunk/src/org/roller/presentation/filters/WeblogPageCacheFilter.java (original)
+++ incubator/roller/trunk/src/org/roller/presentation/filters/WeblogPageCacheFilter.java Mon Dec 26 08:46:44 2005
@@ -115,13 +115,12 @@
                     ResponseContent rc = cacheResponse.getContent();
                     
                     // only cache if this is not a logged in user?
-                    if(!this.excludeOwnerPages || !pageRequest.isLoggedIn()) {
-                        if (rc.getSize() < 100) {
-                            mLogger.debug(
-                                "Page size < 100 bytes: " + key 
-                                + ": " + request.getRequestURL());
+                    if (!this.excludeOwnerPages || !pageRequest.isLoggedIn()) {
+                        if (rc != null && rc.getSize() > 0) {
+                            this.mCache.put(key, rc);
+                        } else if (mLogger.isDebugEnabled()) {
+                            mLogger.debug("Not caching zero length content for key: " + key);
                         }
-                        this.mCache.put(key, rc);
                     } else {
                         mLogger.debug("SKIPPED "+key);
                         this.skips++;