[GitHub] [ozone] sumitagrawl commented on a diff in pull request #4269: HDDS-7931. EC: ManagedChannelImpl not cleaned up properly

["sumitagrawl (via GitHub)" <gi...@apache.org>]

sumitagrawl commented on code in PR #4269:
URL: https://github.com/apache/ozone/pull/4269#discussion_r1105345807


##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/io/KeyOutputStream.java:
##########
@@ -335,7 +335,7 @@ private void handleException(BlockOutputStreamEntry streamEntry,
       excludeList.addPipeline(pipelineId);
     }
     // just clean up the current stream.
-    streamEntry.cleanup(!retryFailure);
+    streamEntry.cleanup(retryFailure);

Review Comment:
   retryFailure is used to invalidate client in cache, recently changed for (HDDS-7838. gRPC channel created block input/output stream not shutdown properly),  so do this revert change will also work for both case and do need invalidate stream in cache for this ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org