You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/07/21 13:33:22 UTC
[GitHub] [beam] steveniemitz opened a new pull request, #22390: Fix UpdateSchemaDestination when source format is set to AVRO
steveniemitz opened a new pull request, #22390:
URL: https://github.com/apache/beam/pull/22390
This fixes part of #22372
R: @pabloem @MarcoRob
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] steveniemitz commented on pull request #22390: Fix UpdateSchemaDestination when source format is set to AVRO
Posted by GitBox <gi...@apache.org>.
steveniemitz commented on PR #22390:
URL: https://github.com/apache/beam/pull/22390#issuecomment-1194037253
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22390: Fix UpdateSchemaDestination when source format is set to AVRO
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22390:
URL: https://github.com/apache/beam/pull/22390#issuecomment-1205183986
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @apilloud for label java.
R: @chamikaramj for label io.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem merged pull request #22390: Fix UpdateSchemaDestination when source format is set to AVRO
Posted by GitBox <gi...@apache.org>.
pabloem merged PR #22390:
URL: https://github.com/apache/beam/pull/22390
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #22390: Fix UpdateSchemaDestination when source format is set to AVRO
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #22390:
URL: https://github.com/apache/beam/pull/22390#issuecomment-1213304511
sorry about the delay. I'd been on vacation. I'll look...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22390: Fix UpdateSchemaDestination when source format is set to AVRO
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22390:
URL: https://github.com/apache/beam/pull/22390#issuecomment-1191598054
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @robertwb for label java.
R: @pabloem for label io.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22390: Fix UpdateSchemaDestination when source format is set to AVRO
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22390:
URL: https://github.com/apache/beam/pull/22390#issuecomment-1202409480
Reminder, please take a look at this pr: @robertwb @pabloem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] steveniemitz commented on pull request #22390: Fix UpdateSchemaDestination when source format is set to AVRO
Posted by GitBox <gi...@apache.org>.
steveniemitz commented on PR #22390:
URL: https://github.com/apache/beam/pull/22390#issuecomment-1193137890
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22390: Fix UpdateSchemaDestination when source format is set to AVRO
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22390:
URL: https://github.com/apache/beam/pull/22390#issuecomment-1213048452
Reminder, please take a look at this pr: @apilloud @chamikaramj
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] steveniemitz commented on pull request #22390: Fix UpdateSchemaDestination when source format is set to AVRO
Posted by GitBox <gi...@apache.org>.
steveniemitz commented on PR #22390:
URL: https://github.com/apache/beam/pull/22390#issuecomment-1191553203
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #22390: Fix UpdateSchemaDestination when source format is set to AVRO
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #22390:
URL: https://github.com/apache/beam/pull/22390#issuecomment-1192737935
sorry I'll be on vacation for a while so I can't review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #22390: Fix UpdateSchemaDestination when source format is set to AVRO
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #22390:
URL: https://github.com/apache/beam/pull/22390#issuecomment-1215461524
lgtm thanks @steveniemitz !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org