You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/08/08 09:01:59 UTC

[GitHub] [incubator-superset] codecov-io commented on issue #8003: Added better display of NULL values in FilterableTable (as in SQL Lab Results)

codecov-io commented on issue #8003: Added better display of NULL values in FilterableTable (as in SQL Lab Results)
URL: https://github.com/apache/incubator-superset/pull/8003#issuecomment-519433847
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8003?src=pr&el=h1) Report
   > Merging [#8003](https://codecov.io/gh/apache/incubator-superset/pull/8003?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b380879c41e785efbaa155a5b20254f619f08093?src=pr&el=desc) will **decrease** coverage by `7.64%`.
   > The diff coverage is `13.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/8003/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/8003?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #8003      +/-   ##
   ==========================================
   - Coverage   73.23%   65.58%   -7.65%     
   ==========================================
     Files         115      469     +354     
     Lines       11839    22437   +10598     
     Branches        0     2438    +2438     
   ==========================================
   + Hits         8670    14716    +6046     
   - Misses       3169     7601    +4432     
   - Partials        0      120     +120
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8003?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...src/components/FilterableTable/FilterableTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0ZpbHRlcmFibGVUYWJsZS9GaWx0ZXJhYmxlVGFibGUuanN4) | `78.61% <13.33%> (ø)` | |
   | [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/8003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `76.69% <0%> (-0.31%)` | :arrow_down: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/8003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.61% <0%> (-0.16%)` | :arrow_down: |
   | [superset/assets/src/components/Checkbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0NoZWNrYm94LmpzeA==) | `100% <0%> (ø)` | |
   | [...ations/deckgl/layers/Polygon/PolygonChartPlugin.js](https://codecov.io/gh/apache/incubator-superset/pull/8003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL1BvbHlnb24vUG9seWdvbkNoYXJ0UGx1Z2luLmpz) | `0% <0%> (ø)` | |
   | [...ets/src/dashboard/components/dnd/DragDroppable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9kbmQvRHJhZ0Ryb3BwYWJsZS5qc3g=) | `94.59% <0%> (ø)` | |
   | [...c/visualizations/deckgl/layers/Polygon/Polygon.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL1BvbHlnb24vUG9seWdvbi5qc3g=) | `0% <0%> (ø)` | |
   | [superset/assets/src/components/EditableTitle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0VkaXRhYmxlVGl0bGUuanN4) | `81.53% <0%> (ø)` | |
   | [superset/assets/src/setup/setupPlugins.js](https://codecov.io/gh/apache/incubator-superset/pull/8003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9zZXR1cC9zZXR1cFBsdWdpbnMuanM=) | `0% <0%> (ø)` | |
   | [...t/assets/src/components/InfoTooltipWithTrigger.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0luZm9Ub29sdGlwV2l0aFRyaWdnZXIuanN4) | `41.66% <0%> (ø)` | |
   | ... and [348 more](https://codecov.io/gh/apache/incubator-superset/pull/8003/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8003?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8003?src=pr&el=footer). Last update [b380879...b630a5f](https://codecov.io/gh/apache/incubator-superset/pull/8003?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org