[GitHub] [airflow] uranusjr commented on a change in pull request #20510: Make container creation configurable when uploading files via WasbHook

[GitBox <gi...@apache.org>]

uranusjr commented on a change in pull request #20510:
URL: https://github.com/apache/airflow/pull/20510#discussion_r816393099



##########
File path: airflow/providers/microsoft/azure/hooks/wasb.py
##########
@@ -291,9 +329,13 @@ def upload(
             ``PageBlob`` or ``AppendBlob``. The default value is ``BlockBlob``.
         :param length: Number of bytes to read from the stream. This is optional,
             but should be supplied for optimal performance.
+        :param try_container_create: Flag to attempt to create the target container prior to uploading the
+            blob. This is useful if the target container may not be known to exist. Defaults to False.

Review comment:
       ```suggestion
           :param try_container_create: Attempt to create the target container prior to uploading the
               blob. This is useful if the target container may not exist yet. Defaults to False.
   ```
   
   The `try` part keeps leading me to Python’s `try` which does not really fit the semantics here. But I don’t have a very good recommendation either.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org