You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by si...@apache.org on 2018/06/04 22:04:03 UTC

[bookkeeper] 09/09: ISSUE #1472: [TABLE SERVICE] TestStorageClientBuilder.testBuildClientInvalidNamespaceName failed

This is an automated email from the ASF dual-hosted git repository.

sijie pushed a commit to branch branch-4.7
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git

commit 96d599e5ee1c304e73591225297066af35553df7
Author: Sijie Guo <si...@apache.org>
AuthorDate: Mon Jun 4 00:57:09 2018 -0700

    ISSUE #1472: [TABLE SERVICE] TestStorageClientBuilder.testBuildClientInvalidNamespaceName failed
    
    Descriptions of the changes in this PR:
    
    *Problem*
    
     #1457 changed the validation of namespace/stream name. so "-" is a valid character.
    
    *Solution*
    
    Fix the test.
    
    Master Issue: #1472
    
    Author: Sijie Guo <si...@apache.org>
    
    Reviewers: Jia Zhai <None>
    
    This closes #1473 from sijie/fix_storage_client_builder, closes #1472
---
 .../java/org/apache/bookkeeper/clients/TestStorageClientBuilder.java    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/stream/clients/java/all/src/test/java/org/apache/bookkeeper/clients/TestStorageClientBuilder.java b/stream/clients/java/all/src/test/java/org/apache/bookkeeper/clients/TestStorageClientBuilder.java
index 39bd14a..daef4ed 100644
--- a/stream/clients/java/all/src/test/java/org/apache/bookkeeper/clients/TestStorageClientBuilder.java
+++ b/stream/clients/java/all/src/test/java/org/apache/bookkeeper/clients/TestStorageClientBuilder.java
@@ -50,7 +50,7 @@ public class TestStorageClientBuilder {
             .withSettings(StorageClientSettings.newBuilder()
                 .serviceUri("bk://localhost:4181")
                 .build())
-            .withNamespace("invalid-namespace")
+            .withNamespace("invalid namespace")
             .build();
     }
 

-- 
To stop receiving notification emails like this one, please contact
sijie@apache.org.