You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <ma...@gmail.com> on 2016/01/12 10:22:50 UTC
Review Request 42183: Introduced HttpEvent based filters in
libprocess.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42183/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-4255
https://issues.apache.org/jira/browse/MESOS-4255
Repository: mesos
Description
-------
This change introduces the ability to filter `HTTPEvent` in libprocess similar to the already existing `MessageEvent` and `DispatchEvent`.
Diffs
-----
3rdparty/libprocess/include/process/gmock.hpp 53fdb15ef8d0c6bb95a974be416ce1922a211064
Diff: https://reviews.apache.org/r/42183/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 42183: Introduced HttpEvent based filters in
libprocess.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42183/#review116507
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Jan. 27, 2016, 1:17 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42183/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2016, 1:17 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-4425
> https://issues.apache.org/jira/browse/MESOS-4425
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change introduces the ability to filter `HTTPEvent` in libprocess similar to the already existing `MessageEvent` and `DispatchEvent`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/gmock.hpp 53fdb15ef8d0c6bb95a974be416ce1922a211064
>
> Diff: https://reviews.apache.org/r/42183/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 42183: Introduced HttpEvent based filters in
libprocess.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42183/
-----------------------------------------------------------
(Updated Jan. 27, 2016, 1:17 a.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Review comment from Vinod
Bugs: MESOS-4425
https://issues.apache.org/jira/browse/MESOS-4425
Repository: mesos
Description
-------
This change introduces the ability to filter `HTTPEvent` in libprocess similar to the already existing `MessageEvent` and `DispatchEvent`.
Diffs (updated)
-----
3rdparty/libprocess/include/process/gmock.hpp 53fdb15ef8d0c6bb95a974be416ce1922a211064
Diff: https://reviews.apache.org/r/42183/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 42183: Introduced HttpEvent based filters in
libprocess.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42183/#review116480
-----------------------------------------------------------
3rdparty/libprocess/include/process/gmock.hpp (line 369)
<https://reviews.apache.org/r/42183/#comment177496>
Use the same/similar comment as at #331.
- Vinod Kone
On Jan. 22, 2016, 8:24 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42183/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2016, 8:24 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-4425
> https://issues.apache.org/jira/browse/MESOS-4425
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change introduces the ability to filter `HTTPEvent` in libprocess similar to the already existing `MessageEvent` and `DispatchEvent`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/gmock.hpp 53fdb15ef8d0c6bb95a974be416ce1922a211064
>
> Diff: https://reviews.apache.org/r/42183/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 42183: Introduced HttpEvent based filters in
libprocess.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42183/
-----------------------------------------------------------
(Updated Jan. 22, 2016, 8:24 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Updated Depends On
Bugs: MESOS-4425
https://issues.apache.org/jira/browse/MESOS-4425
Repository: mesos
Description
-------
This change introduces the ability to filter `HTTPEvent` in libprocess similar to the already existing `MessageEvent` and `DispatchEvent`.
Diffs
-----
3rdparty/libprocess/include/process/gmock.hpp 53fdb15ef8d0c6bb95a974be416ce1922a211064
Diff: https://reviews.apache.org/r/42183/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 42183: Introduced HttpEvent based filters in
libprocess.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42183/
-----------------------------------------------------------
(Updated Jan. 19, 2016, 10:29 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Updated Deps
Bugs: MESOS-4425
https://issues.apache.org/jira/browse/MESOS-4425
Repository: mesos
Description
-------
This change introduces the ability to filter `HTTPEvent` in libprocess similar to the already existing `MessageEvent` and `DispatchEvent`.
Diffs
-----
3rdparty/libprocess/include/process/gmock.hpp 53fdb15ef8d0c6bb95a974be416ce1922a211064
Diff: https://reviews.apache.org/r/42183/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 42183: Introduced HttpEvent based filters in
libprocess.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42183/
-----------------------------------------------------------
(Updated Jan. 19, 2016, 2:10 a.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Updated JIRA link in Bugs.
Bugs: MESOS-4425
https://issues.apache.org/jira/browse/MESOS-4425
Repository: mesos
Description
-------
This change introduces the ability to filter `HTTPEvent` in libprocess similar to the already existing `MessageEvent` and `DispatchEvent`.
Diffs
-----
3rdparty/libprocess/include/process/gmock.hpp 53fdb15ef8d0c6bb95a974be416ce1922a211064
Diff: https://reviews.apache.org/r/42183/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar