You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/04/17 15:27:36 UTC

[GitHub] [airflow] ashb commented on a change in pull request #8423: Fix Snowflake hook conn id

ashb commented on a change in pull request #8423: Fix Snowflake hook conn id
URL: https://github.com/apache/airflow/pull/8423#discussion_r410298189
 
 

 ##########
 File path: tests/providers/snowflake/hooks/test_snowflake.py
 ##########
 @@ -102,6 +102,7 @@ def test_get_conn_params(self):
                                 'warehouse': 'af_wh',
                                 'region': 'af_region',
                                 'role': 'af_role'}
+        self.assertEqual(self.db_hook.snowflake_conn_id, 'snowflake_default')
 
 Review comment:
   I _think_ that this is actually a change in the default, and `snowflake_conn_id` was the previous default.
   
   Do you think it's worth changing this default? If so it needs a note in UPDATING.md

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services