You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@phoenix.apache.org by ja...@apache.org on 2014/11/08 06:52:54 UTC
phoenix git commit: PHOENIX-1420 DatabaseMetaData.getschemas returns
incorrect column order
Repository: phoenix
Updated Branches:
refs/heads/3.0 bef7c0ed2 -> b5012d994
PHOENIX-1420 DatabaseMetaData.getschemas returns incorrect column order
Project: http://git-wip-us.apache.org/repos/asf/phoenix/repo
Commit: http://git-wip-us.apache.org/repos/asf/phoenix/commit/b5012d99
Tree: http://git-wip-us.apache.org/repos/asf/phoenix/tree/b5012d99
Diff: http://git-wip-us.apache.org/repos/asf/phoenix/diff/b5012d99
Branch: refs/heads/3.0
Commit: b5012d994278982c287b18b9051616cd76ac8b80
Parents: bef7c0e
Author: James Taylor <jt...@salesforce.com>
Authored: Fri Nov 7 21:44:15 2014 -0800
Committer: James Taylor <jt...@salesforce.com>
Committed: Fri Nov 7 21:51:15 2014 -0800
----------------------------------------------------------------------
.../java/org/apache/phoenix/end2end/QueryDatabaseMetaDataIT.java | 4 ++--
.../java/org/apache/phoenix/jdbc/PhoenixDatabaseMetaData.java | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/phoenix/blob/b5012d99/phoenix-core/src/it/java/org/apache/phoenix/end2end/QueryDatabaseMetaDataIT.java
----------------------------------------------------------------------
diff --git a/phoenix-core/src/it/java/org/apache/phoenix/end2end/QueryDatabaseMetaDataIT.java b/phoenix-core/src/it/java/org/apache/phoenix/end2end/QueryDatabaseMetaDataIT.java
index 83bb91d..0f1f74b 100644
--- a/phoenix-core/src/it/java/org/apache/phoenix/end2end/QueryDatabaseMetaDataIT.java
+++ b/phoenix-core/src/it/java/org/apache/phoenix/end2end/QueryDatabaseMetaDataIT.java
@@ -168,8 +168,8 @@ public class QueryDatabaseMetaDataIT extends BaseClientManagedTimeIT {
ResultSet rs;
rs = dbmd.getSchemas(null, CUSTOM_ENTITY_DATA_SCHEMA_NAME);
assertTrue(rs.next());
- assertEquals(rs.getString("TABLE_SCHEM"),CUSTOM_ENTITY_DATA_SCHEMA_NAME);
- assertEquals(rs.getString("TABLE_CATALOG"),null);
+ assertEquals(rs.getString(1),CUSTOM_ENTITY_DATA_SCHEMA_NAME);
+ assertEquals(rs.getString(2),null);
assertFalse(rs.next());
rs = dbmd.getSchemas(null, null);
http://git-wip-us.apache.org/repos/asf/phoenix/blob/b5012d99/phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixDatabaseMetaData.java
----------------------------------------------------------------------
diff --git a/phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixDatabaseMetaData.java b/phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixDatabaseMetaData.java
index 5f2e8b8..4e35e2c 100644
--- a/phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixDatabaseMetaData.java
+++ b/phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixDatabaseMetaData.java
@@ -874,8 +874,8 @@ public class PhoenixDatabaseMetaData implements DatabaseMetaData, org.apache.pho
@Override
public ResultSet getSchemas(String catalog, String schemaPattern) throws SQLException {
StringBuilder buf = new StringBuilder("select distinct \n" +
- TENANT_ID + " " + TABLE_CATALOG + "," + // no catalog for tables
- TABLE_SCHEM +
+ TABLE_SCHEM + "," +
+ TENANT_ID + " " + TABLE_CATALOG +
" from " + SYSTEM_CATALOG + " " + SYSTEM_CATALOG_ALIAS +
" where " + COLUMN_NAME + " is null");
this.addTenantIdFilter(buf, catalog);