You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "raulcd (via GitHub)" <gi...@apache.org> on 2023/07/12 10:20:39 UTC

[GitHub] [arrow] raulcd opened a new issue, #36634: [Dev] Merge PR script defaults to the wrong milestone when merging

raulcd opened a new issue, #36634:
URL: https://github.com/apache/arrow/issues/36634

   ### Describe the bug, including details regarding any error messages, version, and platform.
   
   I saw that lots of PRs were merged with the wrong milestone (13.0.0) now that the maintenance branch has been created it should default to 14.0.0 but it is not as seen:
   ```
   Would you like to update the associated issue? (y/n): y
   Enter fix version [13.0.0]:
   ```
   It does seem that the `12.0.0` and `12.0.1` maintenance branches are also not shown:
   ```
   (Pdb) pr.maintenance_branches
   ['maint-0.11.x', 'maint-0.12.x', 'maint-0.14.x', 'maint-0.15.x', 'maint-0.17.x', 'maint-1.0.x', 'maint-3.0.x', 'maint-4.0.x', 'maint-6.0.x', 'maint-7.0.x', 'maint-7.0.1', 'maint-8.0.x', 'maint-9.0.0', 'maint-10.0.x', 'maint-10.0.0', 'maint-10.0.1', 'maint-11.0.0']
   (Pdb) 
   ```
   It might be due to pagination when requesting branches:
   ```
       def get_branches(self):
           return get_json("%s/branches" % (self.github_api),
                           headers=self.headers)
   ```
   
   
   ### Component(s)
   
   Developer Tools


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] raulcd commented on issue #36634: [Dev] Merge PR script defaults to the wrong milestone when merging

Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on issue #36634:
URL: https://github.com/apache/arrow/issues/36634#issuecomment-1632488185

   @kou there are some branches which I am unsure should be on the repo, like old RC branches or some feature branches like:
   [decimal256](https://github.com/apache/arrow/tree/decimal256)
   [new-contrib-language](https://github.com/apache/arrow/tree/new-contrib-language)
   [flight-sql-jdbc](https://github.com/apache/arrow/tree/flight-sql-jdbc)
   [ibis-remove-string-contains](https://github.com/apache/arrow/tree/ibis-remove-string-contains)
   [dom/aray](https://github.com/apache/arrow/tree/dom/aray)
   
   I think all those can be removed, for the ols RC ones we have the release and the maintenance branch. Are you ok with me removing those?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] raulcd commented on issue #36634: [Dev] Merge PR script defaults to the wrong milestone when merging

Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on issue #36634:
URL: https://github.com/apache/arrow/issues/36634#issuecomment-1633813650

   Thanks @kou , I've removed:
   [decimal256](https://github.com/apache/arrow/tree/decimal256)
   [flight-sql-jdbc](https://github.com/apache/arrow/tree/flight-sql-jdbc)
   [ibis-remove-string-contains](https://github.com/apache/arrow/tree/ibis-remove-string-contains)
   and all the release candidate branches for old releases.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kou commented on issue #36634: [Dev] Merge PR script defaults to the wrong milestone when merging

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #36634:
URL: https://github.com/apache/arrow/issues/36634#issuecomment-1633560724

   Yes. Could you remove them?
   
   > [decimal256](https://github.com/apache/arrow/tree/decimal256)
   
   This was merged by #8475
   
   > * [new-contrib-language](https://github.com/apache/arrow/tree/new-contrib-language)
   
   This was merged by #13217 and I removed it now.
   
   > [flight-sql-jdbc](https://github.com/apache/arrow/tree/flight-sql-jdbc)
   
   This was merged by #13800.
   
   > [ibis-remove-string-contains](https://github.com/apache/arrow/tree/ibis-remove-string-contains)
   
   This is garbage.
   
   > [dom/aray](https://github.com/apache/arrow/tree/dom/aray)
   
   This was merged by #35772 and I removed it now.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kou closed issue #36634: [Dev] Merge PR script defaults to the wrong milestone when merging

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou closed issue #36634: [Dev] Merge PR script defaults to the wrong milestone when merging
URL: https://github.com/apache/arrow/issues/36634


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org