You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/07/27 19:10:29 UTC
Re: Review Request 67751: Add missing files to CMake build.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67751/
-----------------------------------------------------------
(Updated July 27, 2018, 12:10 p.m.)
Review request for mesos, Benjamin Bannier, Benjamin Mahler, James Peach, and Joseph Wu.
Changes
-------
Split out unrelated changes and addressed review.
Summary (updated)
-----------------
Add missing files to CMake build.
Bugs: MESOS-8994
https://issues.apache.org/jira/browse/MESOS-8994
Repository: mesos
Description (updated)
-------
This patch adds stubs for the Python executor and scheduler, adds
support for `mesos-resolve`, adds conditional support for the old
`mesos-cli` when `ENABLE_NEW_CLI` is not set, and fixes some ordering
oddities.
Diffs (updated)
-----
src/CMakeLists.txt 10b0946d6f49c7e9c201bad6f9f1b41cc8460fe5
src/Makefile.am 71f9052f60fc65d8183faa7ab9764d3e6388ddc9
src/cli/CMakeLists.txt 7b2abf2fe14888ec1da11414189f71da972ac427
src/python/executor/CMakeLists.txt PRE-CREATION
src/python/scheduler/CMakeLists.txt PRE-CREATION
src/tests/CMakeLists.txt 695b6f543847d4270f7004a1768919904975d7a4
Diff: https://reviews.apache.org/r/67751/diff/2/
Changes: https://reviews.apache.org/r/67751/diff/1-2/
Testing (updated)
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 67751: Add missing files to CMake build.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67751/#review206735
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Bannier
On July 28, 2018, 12:26 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67751/
> -----------------------------------------------------------
>
> (Updated July 28, 2018, 12:26 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, James Peach, and Joseph Wu.
>
>
> Bugs: MESOS-8994
> https://issues.apache.org/jira/browse/MESOS-8994
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds stubs for the Python executor and scheduler, adds
> support for `mesos-resolve`, adds conditional support for the old
> `mesos-cli` when `ENABLE_NEW_CLI` is not set and not on Windows, and
> fixes some ordering oddities.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 10b0946d6f49c7e9c201bad6f9f1b41cc8460fe5
> src/Makefile.am 71f9052f60fc65d8183faa7ab9764d3e6388ddc9
> src/cli/CMakeLists.txt 7b2abf2fe14888ec1da11414189f71da972ac427
> src/python/executor/CMakeLists.txt PRE-CREATION
> src/python/scheduler/CMakeLists.txt PRE-CREATION
> src/tests/CMakeLists.txt 695b6f543847d4270f7004a1768919904975d7a4
>
>
> Diff: https://reviews.apache.org/r/67751/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 67751: Add missing files to CMake build.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67751/
-----------------------------------------------------------
(Updated July 27, 2018, 3:26 p.m.)
Review request for mesos, Benjamin Bannier, Benjamin Mahler, James Peach, and Joseph Wu.
Changes
-------
Fix to not break on Windows.
Bugs: MESOS-8994
https://issues.apache.org/jira/browse/MESOS-8994
Repository: mesos
Description (updated)
-------
This patch adds stubs for the Python executor and scheduler, adds
support for `mesos-resolve`, adds conditional support for the old
`mesos-cli` when `ENABLE_NEW_CLI` is not set and not on Windows, and
fixes some ordering oddities.
Diffs (updated)
-----
src/CMakeLists.txt 10b0946d6f49c7e9c201bad6f9f1b41cc8460fe5
src/Makefile.am 71f9052f60fc65d8183faa7ab9764d3e6388ddc9
src/cli/CMakeLists.txt 7b2abf2fe14888ec1da11414189f71da972ac427
src/python/executor/CMakeLists.txt PRE-CREATION
src/python/scheduler/CMakeLists.txt PRE-CREATION
src/tests/CMakeLists.txt 695b6f543847d4270f7004a1768919904975d7a4
Diff: https://reviews.apache.org/r/67751/diff/3/
Changes: https://reviews.apache.org/r/67751/diff/2-3/
Testing
-------
Thanks,
Andrew Schwartzmeyer