You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/09/21 13:21:47 UTC
[GitHub] [shardingsphere] sluk3r opened a new pull request #7541: Problem AbstractBootstrapInitializerTest#init solved
sluk3r opened a new pull request #7541:
URL: https://github.com/apache/shardingsphere/pull/7541
Fixes #7538.
Changes proposed in this pull request:
- sleep time changed to 900 ms
- for two child class, proxy port set to 2020 and 3030 respectively
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sluk3r commented on pull request #7541: Problem AbstractBootstrapInitializerTest#init solved
Posted by GitBox <gi...@apache.org>.
sluk3r commented on pull request #7541:
URL: https://github.com/apache/shardingsphere/pull/7541#issuecomment-696127900
> I refactor some place, but this pr revert my changes, what is the reason?
restored
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on a change in pull request #7541: Problem AbstractBootstrapInitializerTest#init solved
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #7541:
URL: https://github.com/apache/shardingsphere/pull/7541#discussion_r492461066
##########
File path: shardingsphere-proxy/shardingsphere-proxy-bootstrap/src/main/java/org/apache/shardingsphere/proxy/init/impl/AbstractBootstrapInitializer.java
##########
@@ -55,6 +55,8 @@
@Slf4j
public abstract class AbstractBootstrapInitializer implements BootstrapInitializer {
+ private ShardingSphereProxy shardingSphereProxy = new ShardingSphereProxy();
Review comment:
It is better to make the field as final
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls commented on pull request #7541: Problem AbstractBootstrapInitializerTest#init solved
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #7541:
URL: https://github.com/apache/shardingsphere/pull/7541#issuecomment-696249445
## Pull Request Test Coverage Report for [Build 14962](https://coveralls.io/builds/33612243)
* **2** of **2** **(100.0%)** changed or added relevant lines in **1** file are covered.
* **61** unchanged lines in **3** files lost coverage.
* Overall coverage decreased (**-0.004%**) to **35.082%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [shardingsphere-infra/shardingsphere-infra-context/src/main/java/org/apache/shardingsphere/infra/context/kernel/KernelProcessor.java](https://coveralls.io/builds/33612243/source?filename=shardingsphere-infra%2Fshardingsphere-infra-context%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Finfra%2Fcontext%2Fkernel%2FKernelProcessor.java#L37) | 5 | 0% |
| [shardingsphere-jdbc/shardingsphere-jdbc-core/src/main/java/org/apache/shardingsphere/driver/jdbc/core/statement/ShardingSpherePreparedStatement.java](https://coveralls.io/builds/33612243/source?filename=shardingsphere-jdbc%2Fshardingsphere-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fdriver%2Fjdbc%2Fcore%2Fstatement%2FShardingSpherePreparedStatement.java#L112) | 22 | 82.05% |
| [shardingsphere-jdbc/shardingsphere-jdbc-core/src/main/java/org/apache/shardingsphere/driver/jdbc/core/statement/ShardingSphereStatement.java](https://coveralls.io/builds/33612243/source?filename=shardingsphere-jdbc%2Fshardingsphere-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fdriver%2Fjdbc%2Fcore%2Fstatement%2FShardingSphereStatement.java#L150) | 34 | 67.81% |
<!-- | **Total:** | **61** | | -->
| Totals | [](https://coveralls.io/builds/33612243) |
| :-- | --: |
| Change from base [Build 14949](https://coveralls.io/builds/33608175): | -0.004% |
| Covered Lines: | 36589 |
| Relevant Lines: | 104297 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on a change in pull request #7541: Problem AbstractBootstrapInitializerTest#init solved
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #7541:
URL: https://github.com/apache/shardingsphere/pull/7541#discussion_r492461066
##########
File path: shardingsphere-proxy/shardingsphere-proxy-bootstrap/src/main/java/org/apache/shardingsphere/proxy/init/impl/AbstractBootstrapInitializer.java
##########
@@ -55,6 +55,8 @@
@Slf4j
public abstract class AbstractBootstrapInitializer implements BootstrapInitializer {
+ private ShardingSphereProxy shardingSphereProxy = new ShardingSphereProxy();
Review comment:
It is better to make the field as final
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #7541: Problem AbstractBootstrapInitializerTest#init solved
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #7541:
URL: https://github.com/apache/shardingsphere/pull/7541
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls edited a comment on pull request #7541: Problem AbstractBootstrapInitializerTest#init solved
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #7541:
URL: https://github.com/apache/shardingsphere/pull/7541#issuecomment-696249445
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls edited a comment on pull request #7541: Problem AbstractBootstrapInitializerTest#init solved
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #7541:
URL: https://github.com/apache/shardingsphere/pull/7541#issuecomment-696249445
## Pull Request Test Coverage Report for [Build 14963](https://coveralls.io/builds/33620916)
* **2** of **2** **(100.0%)** changed or added relevant lines in **1** file are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage increased (+**0.002%**) to **35.082%**
---
| Totals | [](https://coveralls.io/builds/33620916) |
| :-- | --: |
| Change from base [Build 14959](https://coveralls.io/builds/33610642): | 0.002% |
| Covered Lines: | 36589 |
| Relevant Lines: | 104297 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sluk3r commented on a change in pull request #7541: Problem AbstractBootstrapInitializerTest#init solved
Posted by GitBox <gi...@apache.org>.
sluk3r commented on a change in pull request #7541:
URL: https://github.com/apache/shardingsphere/pull/7541#discussion_r492475793
##########
File path: shardingsphere-proxy/shardingsphere-proxy-bootstrap/src/main/java/org/apache/shardingsphere/proxy/init/impl/AbstractBootstrapInitializer.java
##########
@@ -55,6 +55,8 @@
@Slf4j
public abstract class AbstractBootstrapInitializer implements BootstrapInitializer {
+ private ShardingSphereProxy shardingSphereProxy = new ShardingSphereProxy();
Review comment:
make the field as final
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #7541: Problem AbstractBootstrapInitializerTest#init solved
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #7541:
URL: https://github.com/apache/shardingsphere/pull/7541
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls edited a comment on pull request #7541: Problem AbstractBootstrapInitializerTest#init solved
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #7541:
URL: https://github.com/apache/shardingsphere/pull/7541#issuecomment-696249445
## Pull Request Test Coverage Report for [Build 14963](https://coveralls.io/builds/33620916)
* **2** of **2** **(100.0%)** changed or added relevant lines in **1** file are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage increased (+**0.002%**) to **35.082%**
---
| Totals | [](https://coveralls.io/builds/33620916) |
| :-- | --: |
| Change from base [Build 14959](https://coveralls.io/builds/33610642): | 0.002% |
| Covered Lines: | 36589 |
| Relevant Lines: | 104297 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sluk3r commented on a change in pull request #7541: Problem AbstractBootstrapInitializerTest#init solved
Posted by GitBox <gi...@apache.org>.
sluk3r commented on a change in pull request #7541:
URL: https://github.com/apache/shardingsphere/pull/7541#discussion_r492475793
##########
File path: shardingsphere-proxy/shardingsphere-proxy-bootstrap/src/main/java/org/apache/shardingsphere/proxy/init/impl/AbstractBootstrapInitializer.java
##########
@@ -55,6 +55,8 @@
@Slf4j
public abstract class AbstractBootstrapInitializer implements BootstrapInitializer {
+ private ShardingSphereProxy shardingSphereProxy = new ShardingSphereProxy();
Review comment:
make the field as final
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls commented on pull request #7541: Problem AbstractBootstrapInitializerTest#init solved
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #7541:
URL: https://github.com/apache/shardingsphere/pull/7541#issuecomment-696249445
## Pull Request Test Coverage Report for [Build 14962](https://coveralls.io/builds/33612243)
* **2** of **2** **(100.0%)** changed or added relevant lines in **1** file are covered.
* **61** unchanged lines in **3** files lost coverage.
* Overall coverage decreased (**-0.004%**) to **35.082%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [shardingsphere-infra/shardingsphere-infra-context/src/main/java/org/apache/shardingsphere/infra/context/kernel/KernelProcessor.java](https://coveralls.io/builds/33612243/source?filename=shardingsphere-infra%2Fshardingsphere-infra-context%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Finfra%2Fcontext%2Fkernel%2FKernelProcessor.java#L37) | 5 | 0% |
| [shardingsphere-jdbc/shardingsphere-jdbc-core/src/main/java/org/apache/shardingsphere/driver/jdbc/core/statement/ShardingSpherePreparedStatement.java](https://coveralls.io/builds/33612243/source?filename=shardingsphere-jdbc%2Fshardingsphere-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fdriver%2Fjdbc%2Fcore%2Fstatement%2FShardingSpherePreparedStatement.java#L112) | 22 | 82.05% |
| [shardingsphere-jdbc/shardingsphere-jdbc-core/src/main/java/org/apache/shardingsphere/driver/jdbc/core/statement/ShardingSphereStatement.java](https://coveralls.io/builds/33612243/source?filename=shardingsphere-jdbc%2Fshardingsphere-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fdriver%2Fjdbc%2Fcore%2Fstatement%2FShardingSphereStatement.java#L150) | 34 | 67.81% |
<!-- | **Total:** | **61** | | -->
| Totals | [](https://coveralls.io/builds/33612243) |
| :-- | --: |
| Change from base [Build 14949](https://coveralls.io/builds/33608175): | -0.004% |
| Covered Lines: | 36589 |
| Relevant Lines: | 104297 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sluk3r commented on pull request #7541: Problem AbstractBootstrapInitializerTest#init solved
Posted by GitBox <gi...@apache.org>.
sluk3r commented on pull request #7541:
URL: https://github.com/apache/shardingsphere/pull/7541#issuecomment-696127900
> I refactor some place, but this pr revert my changes, what is the reason?
restored
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls edited a comment on pull request #7541: Problem AbstractBootstrapInitializerTest#init solved
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #7541:
URL: https://github.com/apache/shardingsphere/pull/7541#issuecomment-696249445
## Pull Request Test Coverage Report for [Build 14967](https://coveralls.io/builds/33625758)
* **2** of **2** **(100.0%)** changed or added relevant lines in **1** file are covered.
* **31** unchanged lines in **7** files lost coverage.
* Overall coverage increased (+**0.03%**) to **35.11%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [shardingsphere-features/shardingsphere-encrypt/shardingsphere-encrypt-rewrite/src/main/java/org/apache/shardingsphere/encrypt/rewrite/token/generator/impl/EncryptAssignmentTokenGenerator.java](https://coveralls.io/builds/33625758/source?filename=shardingsphere-features%2Fshardingsphere-encrypt%2Fshardingsphere-encrypt-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Frewrite%2Ftoken%2Fgenerator%2Fimpl%2FEncryptAssignmentTokenGenerator.java#L84) | 1 | 98.08% |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/statement/dml/UpdateStatement.java](https://coveralls.io/builds/33625758/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-statement%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fcommon%2Fstatement%2Fdml%2FUpdateStatement.java#L48) | 1 | 50.0% |
| [shardingsphere-features/shardingsphere-encrypt/shardingsphere-encrypt-rewrite/src/main/java/org/apache/shardingsphere/encrypt/rewrite/token/generator/impl/EncryptInsertOnUpdateTokenGenerator.java](https://coveralls.io/builds/33625758/source?filename=shardingsphere-features%2Fshardingsphere-encrypt%2Fshardingsphere-encrypt-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Frewrite%2Ftoken%2Fgenerator%2Fimpl%2FEncryptInsertOnUpdateTokenGenerator.java#L60) | 2 | 96.15% |
| [shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-route/src/main/java/org/apache/shardingsphere/sharding/route/engine/validator/impl/ShardingDeleteStatementValidator.java](https://coveralls.io/builds/33625758/source?filename=shardingsphere-features%2Fshardingsphere-sharding%2Fshardingsphere-sharding-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Froute%2Fengine%2Fvalidator%2Fimpl%2FShardingDeleteStatementValidator.java#L42) | 3 | 50.0% |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/segment/select/pagination/engine/PaginationContextEngine.java](https://coveralls.io/builds/33625758/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fsegment%2Fselect%2Fpagination%2Fengine%2FPaginationContextEngine.java#L56) | 3 | 61.9% |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/statement/dml/SelectStatement.java](https://coveralls.io/builds/33625758/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-statement%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fcommon%2Fstatement%2Fdml%2FSelectStatement.java#L54) | 3 | 25.0% |
| [shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-route/src/main/java/org/apache/shardingsphere/sharding/route/engine/validator/impl/ShardingUpdateStatementValidator.java](https://coveralls.io/builds/33625758/source?filename=shardingsphere-features%2Fshardingsphere-sharding%2Fshardingsphere-sharding-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Froute%2Fengine%2Fvalidator%2Fimpl%2FShardingUpdateStatementValidator.java#L76) | 18 | 52.78% |
<!-- | **Total:** | **31** | | -->
| Totals | [](https://coveralls.io/builds/33625758) |
| :-- | --: |
| Change from base [Build 14959](https://coveralls.io/builds/33610642): | 0.03% |
| Covered Lines: | 36634 |
| Relevant Lines: | 104341 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org