You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "0yukali0 (via GitHub)" <gi...@apache.org> on 2023/05/10 05:44:33 UTC
[GitHub] [yunikorn-web] 0yukali0 opened a new pull request, #114: [YUNIKORN-1638] Updating REST API in the json-db
0yukali0 opened a new pull request, #114:
URL: https://github.com/apache/yunikorn-web/pull/114
### What is this PR for?
Current data in the json-db miss some field or they have some deprecated fields.
Update the data in the json-db and json-route.
### What type of PR is it?
* [ ] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
* [x] - Task
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1638
### How should this be tested?
run `make json-server` and check the related URLs.
or run the 'make start-dev' to receive the data from the json-server to reveal the results.
### Screenshots (if appropriate)
<img width="1487" alt="image" src="https://github.com/apache/yunikorn-web/assets/45888688/6cdf804c-bf83-4304-94a3-c41ce1d9a9c7">
<img width="1487" alt="image" src="https://github.com/apache/yunikorn-web/assets/45888688/8b387f59-5f09-4021-b54d-85fa5e9038bc">
<img width="1487" alt="image" src="https://github.com/apache/yunikorn-web/assets/45888688/d19ca969-cbc6-4128-87b5-d2ef5166e20a">
<img width="1487" alt="image" src="https://github.com/apache/yunikorn-web/assets/45888688/96a75662-404a-4f93-b34e-9e0a9ea7071c">
<img width="1487" alt="image" src="https://github.com/apache/yunikorn-web/assets/45888688/821be3c2-77a9-4507-8d6d-7721b77ee483">
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-web] codecov-commenter commented on pull request #114: [YUNIKORN-1638] Updating REST API in the json-db
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #114:
URL: https://github.com/apache/yunikorn-web/pull/114#issuecomment-1541390779
## [Codecov](https://app.codecov.io/gh/apache/yunikorn-web/pull/114?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#114](https://app.codecov.io/gh/apache/yunikorn-web/pull/114?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (602efaa) into [master](https://app.codecov.io/gh/apache/yunikorn-web/commit/42f07deecf75bec57d6fa474e8994a5f8eb65975?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (42f07de) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #114 +/- ##
=======================================
Coverage 66.66% 66.66%
=======================================
Files 1 1
Lines 30 30
=======================================
Hits 20 20
Misses 7 7
Partials 3 3
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-web] wilfred-s closed pull request #114: [YUNIKORN-1638] Updating REST API in the json-db
Posted by "wilfred-s (via GitHub)" <gi...@apache.org>.
wilfred-s closed pull request #114: [YUNIKORN-1638] Updating REST API in the json-db
URL: https://github.com/apache/yunikorn-web/pull/114
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org