You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by soralee <gi...@git.apache.org> on 2017/02/27 06:22:28 UTC
[GitHub] zeppelin pull request #2073: ZEPPELIN-2130_do_not_use_webDebPort
GitHub user soralee opened a pull request:
https://github.com/apache/zeppelin/pull/2073
ZEPPELIN-2130_do_not_use_webDebPort
### What is this PR for?
If user uses web application development port such like 9000 which is default value, Zeppelin is not working because of this [line](https://github.com/apache/zeppelin/blob/master/zeppelin-web/src/components/baseUrl/baseUrl.service.js#L27). So, Zeppelin site need to guide this content until fixing this line (I'll improve to flexible web application development port later).
### What type of PR is it?
[ Documentation ]
### What is the Jira issue?
* [ZEPPELIN-2130](https://issues.apache.org/jira/browse/ZEPPELIN-2130)
### How should this be tested?
1. Run document development mode.
2. Connect `http://localhost:4000/install/configuration.html#zeppelin-properties` on browser.
3. Check the description of `ZEPPELIN_PORT`
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/soralee/zeppelin ZEPPELIN-2130_webDevPort_Doc
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2073.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2073
----
commit c634713787414d1014d7b6de5df24f6189228d4e
Author: soralee <so...@zepl.com>
Date: 2017-02-27T05:57:12Z
ZEPPELIN-2130_do_not_use_webDebPort
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2073: [ZEPPELIN-2130][Doc]Do not use web development port
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2073
@AhyoungRyu I just updated that sentence as your describe. could you check again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2073: [ZEPPELIN-2130][Doc]Do not use web development port
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2073
CI is [green](https://travis-ci.org/soralee/zeppelin/builds/206890162) but Jenkins is failed. So I reopen this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2073: [ZEPPELIN-2130][Doc]Do not use web development port
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2073
LGTM \U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2073: [ZEPPELIN-2130][Doc]Do not use web development ...
Posted by soralee <gi...@git.apache.org>.
GitHub user soralee reopened a pull request:
https://github.com/apache/zeppelin/pull/2073
[ZEPPELIN-2130][Doc]Do not use web development port
### What is this PR for?
If user uses web application development port such like 9000 which is default value, Zeppelin is not working because of this [line](https://github.com/apache/zeppelin/blob/master/zeppelin-web/src/components/baseUrl/baseUrl.service.js#L27). So, Zeppelin site need to guide this content until fixing this line (I'll improve to flexible web application development port later).
### What type of PR is it?
[ Documentation ]
### What is the Jira issue?
* [ZEPPELIN-2130](https://issues.apache.org/jira/browse/ZEPPELIN-2130)
### How should this be tested?
1. Run document development mode.
2. Connect `http://localhost:4000/install/configuration.html#zeppelin-properties` on browser.
3. Check the description of `ZEPPELIN_PORT`
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/soralee/zeppelin ZEPPELIN-2130_webDevPort_Doc
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2073.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2073
----
commit ac133ca59fa8a65e991d1d6c1578d42d4119997a
Author: soralee <so...@zepl.com>
Date: 2017-02-27T05:57:12Z
ZEPPELIN-2130_do_not_use_webDebPort
commit ee02c6284ab25c758f7e8f4f4daef002449d08e2
Author: soralee <so...@zepl.com>
Date: 2017-02-27T06:55:28Z
ZEPPELIN-2130_update_sentence
commit 094f29eb54cfbaff0da8bc1fa5d8f9622899aee2
Author: soralee <so...@zepl.com>
Date: 2017-02-27T06:59:23Z
ZEPPELIN-2130_update_sentence
commit 0499bd3c68614ac177e98a2113f5ffe61341940a
Author: soralee <so...@zepl.com>
Date: 2017-02-27T07:38:59Z
ZEPPELIN-2130_update_sentence
commit 8ae57cff10f6d9fe2d07d04d8ebf522294931ab0
Author: soralee <so...@zepl.com>
Date: 2017-02-27T11:46:29Z
ZEPPELIN-2130_remove_dot
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2073: [ZEPPELIN-2130][Doc]Do not use web development ...
Posted by soralee <gi...@git.apache.org>.
Github user soralee closed the pull request at:
https://github.com/apache/zeppelin/pull/2073
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2073: [ZEPPELIN-2130][Doc]Do not use web development port
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2073
Thanks for review @AhyoungRyu @1ambda @felixcheung!
And I updated to remove `.` :smile:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2073: [ZEPPELIN-2130][Doc]Do not use web development port
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2073
Merge into master and branch-0.7 if there are no comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2073: [ZEPPELIN-2130][Doc]Do not use web development port
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2073
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2073: [ZEPPELIN-2130][Doc]Do not use web development ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2073
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2073: [ZEPPELIN-2130][Doc]Do not use web development port
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2073
@soralee Thanks. Looks good!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---