You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by hyunsik <gi...@git.apache.org> on 2014/10/07 19:30:52 UTC

[GitHub] tajo pull request: TAJO-1099: LogicalPlanner::convertDataType caus...

GitHub user hyunsik opened a pull request:

    https://github.com/apache/tajo/pull/185

    TAJO-1099: LogicalPlanner::convertDataType causes NPE in some cases.

    So far, ExprTestBase has not passed through TypeDeterminant in LogicalPlanPreprocessor. So, unit tests haven't caused this problems. 
    
    I fixed the bug and modified LogicalPlanPreprocessor to pass TypeDeterminant in LogicalPlanPreprocessor. As a result, even though this patch does not include any unit tests, it is same as all ExprTestBase tests verify this problem.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hyunsik/tajo TAJO-1099

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/185.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #185
    
----
commit 98a9cfa4778c1bbd035157865e28f57c10622cee
Author: Hyunsik Choi <hy...@apache.org>
Date:   2014-10-07T17:09:20Z

    TAJO-1099: LogicalPlanner::convertDataType causes NPE in some cases.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1099: LogicalPlanner::convertDataType caus...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/tajo/pull/185


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1099: LogicalPlanner::convertDataType caus...

Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:

    https://github.com/apache/tajo/pull/185#issuecomment-58303619
  
    +1
    
    Hi @hyunsik 
    
    Thank you for your contribution.
    It looks good overall and all unit test passed successfully.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---