You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/07/15 22:56:31 UTC

[kudu-CR] benchmarks.sh: fix wire protocol-test runs 

Hello ZhangYao,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/13867

to review the following change.


Change subject: benchmarks.sh: fix wire_protocol-test runs
......................................................................

benchmarks.sh: fix wire_protocol-test runs

Change-Id: Ibce5cc527fae74d2b7028a5b16889b6ee65e55ee
---
M src/kudu/scripts/benchmarks.sh
1 file changed, 6 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/13867/1
-- 
To view, visit http://gerrit.cloudera.org:8080/13867
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibce5cc527fae74d2b7028a5b16889b6ee65e55ee
Gerrit-Change-Number: 13867
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>

[kudu-CR] benchmarks.sh: fix wire protocol-test runs

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13867 )

Change subject: benchmarks.sh: fix wire_protocol-test runs
......................................................................


Patch Set 1: -Verified Code-Review+2

Oops wrong button


-- 
To view, visit http://gerrit.cloudera.org:8080/13867
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibce5cc527fae74d2b7028a5b16889b6ee65e55ee
Gerrit-Change-Number: 13867
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
Gerrit-Comment-Date: Tue, 16 Jul 2019 04:30:03 +0000
Gerrit-HasComments: No

[kudu-CR] benchmarks.sh: fix wire protocol-test runs

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13867 )

Change subject: benchmarks.sh: fix wire_protocol-test runs
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/13867
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibce5cc527fae74d2b7028a5b16889b6ee65e55ee
Gerrit-Change-Number: 13867
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
Gerrit-Comment-Date: Tue, 16 Jul 2019 04:29:03 +0000
Gerrit-HasComments: No

[kudu-CR] benchmarks.sh: fix wire protocol-test runs

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13867 )

Change subject: benchmarks.sh: fix wire_protocol-test runs
......................................................................


Patch Set 1: Code-Review+2

Thank you for the fix!


-- 
To view, visit http://gerrit.cloudera.org:8080/13867
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibce5cc527fae74d2b7028a5b16889b6ee65e55ee
Gerrit-Change-Number: 13867
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
Gerrit-Comment-Date: Tue, 16 Jul 2019 05:05:58 +0000
Gerrit-HasComments: No

[kudu-CR] benchmarks.sh: fix wire protocol-test runs

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13867 )

Change subject: benchmarks.sh: fix wire_protocol-test runs
......................................................................

benchmarks.sh: fix wire_protocol-test runs

Change-Id: Ibce5cc527fae74d2b7028a5b16889b6ee65e55ee
Reviewed-on: http://gerrit.cloudera.org:8080/13867
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/scripts/benchmarks.sh
1 file changed, 6 insertions(+), 3 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Todd Lipcon: Looks good to me, approved
  Alexey Serbin: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/13867
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibce5cc527fae74d2b7028a5b16889b6ee65e55ee
Gerrit-Change-Number: 13867
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>