You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/02/14 16:50:42 UTC
[jira] [Commented] (FLINK-5277) missing unit test for ensuring
ResultPartition#add always recycles buffers
[ https://issues.apache.org/jira/browse/FLINK-5277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15866101#comment-15866101 ]
ASF GitHub Bot commented on FLINK-5277:
---------------------------------------
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/3309
[FLINK-5277] add unit tests for ResultPartition#add() in case of failures
This verifies that the given network buffer is recycled as expected and that
no notifiers are called upon failures to add a buffer.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NicoK/flink flink-5277
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3309.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3309
----
commit dff30ab597065c3253018e2da353e6acbc5a5516
Author: Nico Kruber <ni...@data-artisans.com>
Date: 2017-02-14T16:42:28Z
[FLINK-5277] add unit tests for ResultPartition#add() in case of failures
This verifies that the given network buffer is recycled as expected and that
no notifiers are called upon failures to add a buffer.
----
> missing unit test for ensuring ResultPartition#add always recycles buffers
> --------------------------------------------------------------------------
>
> Key: FLINK-5277
> URL: https://issues.apache.org/jira/browse/FLINK-5277
> Project: Flink
> Issue Type: Improvement
> Components: Network
> Reporter: Nico Kruber
> Assignee: Nico Kruber
>
> We rely on ResultPartition to recycle the buffer if the add calls fails.
> It makes sense to add a special test (to ResultPartitionTest or RecordWriterTest) where we ensure that this actually happens to guard against future behaviour changes in ResultPartition.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)