[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8522: [WIP][dashboard scoped filter] part 3: merge filter scope settings into dashboard redux state

[GitBox <gi...@apache.org>]

etr2460 commented on a change in pull request #8522: [WIP][dashboard scoped filter] part 3: merge filter scope settings into dashboard redux state
URL: https://github.com/apache/incubator-superset/pull/8522#discussion_r343942245
 
 

 ##########
 File path: superset/assets/src/dashboard/containers/Dashboard.jsx
 ##########
 @@ -49,18 +48,15 @@ function mapStateToProps(state) {
     dashboardState,
     charts,
     datasources,
-    // filters prop: All the filter_box's state in this dashboard
+    // filters prop:
+    // All the active filter_box's values and scope in this dashboard, for each filter field.
     // When dashboard is first loaded into browser,
     // its value is from preselect_filters that dashboard owner saved in dashboard's meta data
     // When user start interacting with dashboard, it will be user picked values from all filter_box
     filters: getActiveFilters(),
     slices: sliceEntities.slices,
     layout: dashboardLayout.present,
     impressionId,
-    loadStats: getLoadStatsPerTopLevelComponent({
 
 Review comment:
   why are we removing this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org