You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@wicket.apache.org by duesenklipper <gi...@git.apache.org> on 2018/02/04 09:08:12 UTC

[GitHub] wicket pull request #263: WICKET-6526 check HTTP method for all form submiss...

GitHub user duesenklipper opened a pull request:

    https://github.com/apache/wicket/pull/263

    WICKET-6526 check HTTP method for all form submissions

    this moves the HTTP method check from onFormSubmitted to
    onFormSubmitted(submitter) so that every form submission
    performs this check, instead of only non-ajax requests.
    also adds tests that verify this.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/duesenklipper/wicket wicket7/WICKET-6526-ajaxbutton-methodmismatch

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/wicket/pull/263.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #263
    
----
commit f850e13b6767debf23fd0bc6208187daf0a5d481
Author: Carl-Eric Menzel <ca...@...>
Date:   2018-02-03T23:10:23Z

    WICKET-6526 check HTTP method for all form submissions
    
    this moves the HTTP method check from onFormSubmitted to
    onFormSubmitted(submitter) so that every form submission
    performs this check, instead of only non-ajax requests.
    also adds tests that verify this.

----


---

[GitHub] wicket pull request #263: WICKET-6526 check HTTP method for all form submiss...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/wicket/pull/263


---

[GitHub] wicket pull request #263: WICKET-6526 check HTTP method for all form submiss...

Posted by martin-g <gi...@git.apache.org>.

Github user martin-g commented on a diff in the pull request:

    https://github.com/apache/wicket/pull/263#discussion_r166287202
  
    --- Diff: pom.xml ---
    @@ -1203,6 +1203,27 @@
     				</plugins>
     			</build>
     		</profile>
    +		<profile>
    --- End diff --
    
    This should not be here.


---