You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/03/09 06:55:54 UTC
[GitHub] [dubbo-go] tweitjss opened a new pull request #1078: fix: RPCInvocation.ServiceKey use PATH_KEY instead of INTERFACE_KEY
tweitjss opened a new pull request #1078:
URL: https://github.com/apache/dubbo-go/pull/1078
<!-- Thanks for sending a pull request!
Read https://github.com/apache/dubbo-go/blob/master/contributing.md before commit pull request.
-->
**What this PR does**:
fix RPCInvocation.ServiceKey use INTERFACE_KEY which is different from java
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #1077
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
NONE
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks merged pull request #1078: fix: RPCInvocation.ServiceKey use PATH_KEY instead of INTERFACE_KEY
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #1078:
URL: https://github.com/apache/dubbo-go/pull/1078
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #1078: fix: RPCInvocation.ServiceKey use PATH_KEY instead of INTERFACE_KEY
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #1078:
URL: https://github.com/apache/dubbo-go/pull/1078#discussion_r592070979
##########
File path: protocol/invocation/rpcinvocation_test.go
##########
@@ -0,0 +1,54 @@
+package invocation
Review comment:
pls add apache license on top of this file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] zouyx commented on pull request #1078: fix: RPCInvocation.ServiceKey use PATH_KEY instead of INTERFACE_KEY
Posted by GitBox <gi...@apache.org>.
zouyx commented on pull request #1078:
URL: https://github.com/apache/dubbo-go/pull/1078#issuecomment-794022714
> **What this PR does**:
>
> fix RPCInvocation.ServiceKey use INTERFACE_KEY which is different from java
>
> **Which issue(s) this PR fixes**:
>
> Fixes #1077
>
> **Special notes for your reviewer**:
>
> **Does this PR introduce a user-facing change?**:
>
> ```
> NONE
> ```
@tweitjss Thanks for you contribution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on pull request #1078: fix: RPCInvocation.ServiceKey use PATH_KEY instead of INTERFACE_KEY
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1078:
URL: https://github.com/apache/dubbo-go/pull/1078#issuecomment-793469601
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1078?src=pr&el=h1) Report
> Merging [#1078](https://codecov.io/gh/apache/dubbo-go/pull/1078?src=pr&el=desc) (bc375f7) into [master](https://codecov.io/gh/apache/dubbo-go/commit/9b80e89cc109c4c55400a4593a6517b39ef791b8?el=desc) (9b80e89) will **decrease** coverage by `0.13%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/1078?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1078 +/- ##
==========================================
- Coverage 59.57% 59.43% -0.14%
==========================================
Files 268 268
Lines 13367 13367
==========================================
- Hits 7963 7945 -18
- Misses 4418 4435 +17
- Partials 986 987 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1078?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/1078/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `72.52% <0.00%> (-6.60%)` | :arrow_down: |
| [remoting/kubernetes/registry\_controller.go](https://codecov.io/gh/apache/dubbo-go/pull/1078/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9yZWdpc3RyeV9jb250cm9sbGVyLmdv) | `46.12% <0.00%> (-5.31%)` | :arrow_down: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/1078/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `72.05% <0.00%> (-2.95%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1078/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (ø)` | |
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1078/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `61.62% <0.00%> (+3.48%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1078?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1078?src=pr&el=footer). Last update [9b80e89...bc375f7](https://codecov.io/gh/apache/dubbo-go/pull/1078?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on pull request #1078: fix: RPCInvocation.ServiceKey use PATH_KEY instead of INTERFACE_KEY
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on pull request #1078:
URL: https://github.com/apache/dubbo-go/pull/1078#issuecomment-794882385
firstly, pls move ur target branch from master to 3.0. sencondly, pls add an ut.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org