You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/04/04 12:02:05 UTC

[GitHub] [skywalking-java] lujiajing1126 commented on a diff in pull request #138: [Chore] Fix comment's grammar and modifier's order

lujiajing1126 commented on code in PR #138:
URL: https://github.com/apache/skywalking-java/pull/138#discussion_r841658710


##########
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/ContextManager.java:
##########
@@ -169,7 +169,7 @@ public static AbstractTracerContext awaitFinishAsync(AbstractSpan span) {
     }
 
     /**
-     * If not sure has the active span, use this method, will be cause NPE when has no active span, use
+     * If not sure has the active span, use this method, will be causing NPE when has no active span, use

Review Comment:
   But the grammar is still wrong? 
   
   ```suggestion
        * Using this method will cause NPE if active span does not exist. If one is not sure whether there is an active span, use
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org