[GitHub] [tvm] yongwww commented on a diff in pull request #14348: [Unity] Add More Ops For FX Translator

["yongwww (via GitHub)" <gi...@apache.org>]

yongwww commented on code in PR #14348:
URL: https://github.com/apache/tvm/pull/14348#discussion_r1142867702


##########
tests/python/relax/test_frontend_from_fx.py:
##########
@@ -19,20 +19,51 @@
 import tvm
 from tvm import relax
 import tvm.testing
-from tvm.script.parser import ir as I, relax as R, tir as T
+from tvm.script import ir as I
+from tvm.script import relax as R
+from tvm.script import tir as T
 
 
-def verify_model(torch_model, input_info, binding, expected):
+def verify_model(

Review Comment:
   Question (out scope of this pr) for pt converter verification:  Looks we verify the IR, not very sure if we need to verify the inference result as well?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org