You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/18 09:13:50 UTC
[GitHub] [spark] EnricoMi opened a new pull request, #38297: Add missing s prefix to enable string interpolation
EnricoMi opened a new pull request, #38297:
URL: https://github.com/apache/spark/pull/38297
### What changes were proposed in this pull request?
Adds missing `s` prefix to enable string interpolation.
### Why are the changes needed?
Strings will not contain substituted values but variable names.
### Does this PR introduce _any_ user-facing change?
Log messages will change.
### How was this patch tested?
Not tested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaoyajun02 commented on pull request #38297: [MINOR][CORE][SQL] Add missing s prefix to enable string interpolation
Posted by GitBox <gi...@apache.org>.
gaoyajun02 commented on PR #38297:
URL: https://github.com/apache/spark/pull/38297#issuecomment-1283474565
found some code still missing s, e.g:
https://github.com/apache/spark/blob/0110b1ed88d3c140e1bdf04888740070f1d9d992/core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala#L1886
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #38297: [MINOR][CORE][SQL] Add missing s prefix to enable string interpolation
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #38297:
URL: https://github.com/apache/spark/pull/38297#issuecomment-1282246128
+1, LGTM. Merging to master.
Thank you, @EnricoMi.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] EnricoMi commented on pull request #38297: Add missing s prefix to enable string interpolation
Posted by GitBox <gi...@apache.org>.
EnricoMi commented on PR #38297:
URL: https://github.com/apache/spark/pull/38297#issuecomment-1282073496
@HyukjinKwon minor changes fixing log message strings, hoping this does not require a JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #38297: [MINOR][CORE][SQL] Add missing s prefix to enable string interpolation
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #38297: [MINOR][CORE][SQL] Add missing s prefix to enable string interpolation
URL: https://github.com/apache/spark/pull/38297
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] EnricoMi commented on pull request #38297: [MINOR][CORE][SQL] Add missing s prefix to enable string interpolation
Posted by GitBox <gi...@apache.org>.
EnricoMi commented on PR #38297:
URL: https://github.com/apache/spark/pull/38297#issuecomment-1283552252
And another one:
https://github.com/apache/spark/blob/0110b1ed88d3c140e1bdf04888740070f1d9d992/core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala#L644
Plus five more in tests. Created follow up #38307.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org