[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #962: MINIFICPP-1441 Specify Lua version in Mac CI builds

[GitBox <gi...@apache.org>]

lordgamez commented on a change in pull request #962:
URL: https://github.com/apache/nifi-minifi-cpp/pull/962#discussion_r544404215



##########
File path: .github/workflows/ci.yml
##########
@@ -9,7 +9,7 @@ jobs:
       - id: checkout
         uses: actions/checkout@v2
       - id: install_dependencies
-        run: brew install ossp-uuid boost flex openssl python lua xz libssh2
+        run: brew install lua@5.3 && brew install ossp-uuid boost flex openssl python xz libssh2

Review comment:
       I managed to make it work when lua@5.3 was installed before the other packages in a single brew command, but then it failed in the next github actions command. I thought the order of install is arbitrary if I use a single brew install command so I separated them, but seems it seems not to be the case, as it is still failing. CMake still finds lua5.4 somehow which needs to be removed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org