You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by ramkrish86 <gi...@git.apache.org> on 2016/08/05 05:57:12 UTC
[GitHub] flink pull request #2336: FLINK-4094 Off heap memory deallocation might not ...
GitHub user ramkrish86 opened a pull request:
https://github.com/apache/flink/pull/2336
FLINK-4094 Off heap memory deallocation might not properly work (Ram)
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
Just added a log msg warning the user about using OFFHEAP and PREALLOCATION together. Same comment is added over in the doc also. But not sure if that is enough or we need more information to be added there. But for a user it may not be relevant. Any thoughts?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ramkrish86/flink FLINK-4094
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2336.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2336
----
commit 4e51aaffebeb3ccf530bff9e67c1acd63d90672d
Author: Ramkrishna <ra...@intel.com>
Date: 2016-08-05T05:55:07Z
FLINK-4094 Off heap memory deallocation might not properly work (Ram)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2336: FLINK-4094 Off heap memory deallocation might not ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2336
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2336: FLINK-4094 Off heap memory deallocation might not properl...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2336
Looks good, will merge this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2336: FLINK-4094 Off heap memory deallocation might not properl...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2336
Two small comments, otherwise this looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2336: FLINK-4094 Off heap memory deallocation might not ...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2336#discussion_r73670834
--- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/memory/MemoryManager.java ---
@@ -53,6 +55,7 @@
*/
public class MemoryManager {
+ static final Logger LOG = LoggerFactory.getLogger(MemoryManager.class);
--- End diff --
Would make this `private`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2336: FLINK-4094 Off heap memory deallocation might not ...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2336#discussion_r73670793
--- Diff: docs/setup/config.md ---
@@ -83,7 +83,8 @@ The default fraction for managed memory can be adjusted using the `taskmanager.m
- `taskmanager.memory.segment-size`: The size of memory buffers used by the memory manager and the network stack in bytes (DEFAULT: 32768 (= 32 KiBytes)).
-- `taskmanager.memory.preallocate`: Can be either of `true` or `false`. Specifies whether task managers should allocate all managed memory when starting up. (DEFAULT: false)
+- `taskmanager.memory.preallocate`: Can be either of `true` or `false`. Specifies whether task managers should allocate all managed memory when starting up. (DEFAULT: false). When `taskmanager.memory.off-heap` is set to `true`, then it is advised that this configuration is also set to `true`, because when set to
+`false`, cleaning up of the allocated offheap memory kicks up only when the configured JVM parameter MaxDirectMemorySize is reached by triggering a full GC.
--- End diff --
"kicks up" --> "happens".
The reading flow is easier if this is split into two sentences (I would split at ", because")
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---