You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/13 10:50:37 UTC
[GitHub] [spark] tanelk opened a new pull request #29740: Add more order irrelevant aggregates to EliminateSorts
tanelk opened a new pull request #29740:
URL: https://github.com/apache/spark/pull/29740
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Mark `HyperLogLogPlusPlus` and `BitAggregate` as order irrelevant in `EliminateSorts`.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Performance improvements in some queries
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Generalized an existing UT
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #29740: [SPARK-32868][SQL] Add more order irrelevant aggregates to EliminateSorts
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #29740:
URL: https://github.com/apache/spark/pull/29740#discussion_r487689205
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -1044,7 +1044,7 @@ object EliminateSorts extends Rule[LogicalPlan] {
private def isOrderIrrelevantAggs(aggs: Seq[NamedExpression]): Boolean = {
def isOrderIrrelevantAggFunction(func: AggregateFunction): Boolean = func match {
- case _: Min | _: Max | _: Count => true
+ case _: Min | _: Max | _: Count | _: BitAggregate | _: HyperLogLogPlusPlus => true
Review comment:
`HyperLogLogPlusPlus` is an estimation, will the input order affect the estimation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #29740: [SPARK-32868][SQL] Add more order irrelevant aggregates to EliminateSorts
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #29740:
URL: https://github.com/apache/spark/pull/29740#issuecomment-692069818
NOTE: I added the @tanelk JIRA ID in the contributor list and thanks for your contribution!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29740: [SPARK-32868][SQL] Add more order irrelevant aggregates to EliminateSorts
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29740:
URL: https://github.com/apache/spark/pull/29740#issuecomment-691888172
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29740: [SPARK-32868][SQL] Add more order irrelevant aggregates to EliminateSorts
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29740:
URL: https://github.com/apache/spark/pull/29740#issuecomment-691753487
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29740: [SPARK-32868][SQL] Add more order irrelevant aggregates to EliminateSorts
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29740:
URL: https://github.com/apache/spark/pull/29740#issuecomment-691656140
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #29740: [SPARK-32868][SQL] Add more order irrelevant aggregates to EliminateSorts
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #29740:
URL: https://github.com/apache/spark/pull/29740#discussion_r487716283
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -1044,7 +1044,7 @@ object EliminateSorts extends Rule[LogicalPlan] {
private def isOrderIrrelevantAggs(aggs: Seq[NamedExpression]): Boolean = {
def isOrderIrrelevantAggFunction(func: AggregateFunction): Boolean = func match {
- case _: Min | _: Max | _: Count => true
+ case _: Min | _: Max | _: Count | _: BitAggregate | _: HyperLogLogPlusPlus => true
Review comment:
(IMHO) even if so, we don't have any restriction about the deteminisity of the `HyperLogLogPlusPlus` impmentation. So, adding it in this rule look a bit dangerous.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #29740: [SPARK-32868][SQL] Add more order irrelevant aggregates to EliminateSorts
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #29740:
URL: https://github.com/apache/spark/pull/29740#issuecomment-692067397
Thanks! Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29740: Add more order irrelevant aggregates to EliminateSorts
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29740:
URL: https://github.com/apache/spark/pull/29740#issuecomment-691655551
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tanelk commented on a change in pull request #29740: [SPARK-32868][SQL] Add more order irrelevant aggregates to EliminateSorts
Posted by GitBox <gi...@apache.org>.
tanelk commented on a change in pull request #29740:
URL: https://github.com/apache/spark/pull/29740#discussion_r487692977
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -1044,7 +1044,7 @@ object EliminateSorts extends Rule[LogicalPlan] {
private def isOrderIrrelevantAggs(aggs: Seq[NamedExpression]): Boolean = {
def isOrderIrrelevantAggFunction(func: AggregateFunction): Boolean = func match {
- case _: Min | _: Max | _: Count => true
+ case _: Min | _: Max | _: Count | _: BitAggregate | _: HyperLogLogPlusPlus => true
Review comment:
Internally it uses the hash values. From the hash it calculates the bucket id and the max number of leading zeros for all the inputs for each buckets. All of these are deterministic operations, that do not depend on the order of insertion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29740: [SPARK-32868][SQL] Add more order irrelevant aggregates to EliminateSorts
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29740:
URL: https://github.com/apache/spark/pull/29740#issuecomment-691754913
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29740: [SPARK-32868][SQL] Add more order irrelevant aggregates to EliminateSorts
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29740:
URL: https://github.com/apache/spark/pull/29740#issuecomment-691754716
**[Test build #128613 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128613/testReport)** for PR 29740 at commit [`c2f191e`](https://github.com/apache/spark/commit/c2f191ea2d16c00ff6df3778037ed290d86cf9b6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29740: [SPARK-32868][SQL] Add more order irrelevant aggregates to EliminateSorts
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29740:
URL: https://github.com/apache/spark/pull/29740#issuecomment-691890990
**[Test build #128632 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128632/testReport)** for PR 29740 at commit [`20323c8`](https://github.com/apache/spark/commit/20323c846f54ce4f27c8c34e0b0b51ae4ff510dc).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29740: [SPARK-32868][SQL] Add more order irrelevant aggregates to EliminateSorts
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29740:
URL: https://github.com/apache/spark/pull/29740#issuecomment-692058465
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29740: [SPARK-32868][SQL] Add more order irrelevant aggregates to EliminateSorts
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29740:
URL: https://github.com/apache/spark/pull/29740#issuecomment-691888172
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29740: [SPARK-32868][SQL] Add more order irrelevant aggregates to EliminateSorts
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29740:
URL: https://github.com/apache/spark/pull/29740#issuecomment-691890990
**[Test build #128632 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128632/testReport)** for PR 29740 at commit [`20323c8`](https://github.com/apache/spark/commit/20323c846f54ce4f27c8c34e0b0b51ae4ff510dc).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29740: [SPARK-32868][SQL] Add more order irrelevant aggregates to EliminateSorts
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29740:
URL: https://github.com/apache/spark/pull/29740#issuecomment-691655551
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tanelk commented on a change in pull request #29740: [SPARK-32868][SQL] Add more order irrelevant aggregates to EliminateSorts
Posted by GitBox <gi...@apache.org>.
tanelk commented on a change in pull request #29740:
URL: https://github.com/apache/spark/pull/29740#discussion_r487719206
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -1044,7 +1044,7 @@ object EliminateSorts extends Rule[LogicalPlan] {
private def isOrderIrrelevantAggs(aggs: Seq[NamedExpression]): Boolean = {
def isOrderIrrelevantAggFunction(func: AggregateFunction): Boolean = func match {
- case _: Min | _: Max | _: Count => true
+ case _: Min | _: Max | _: Count | _: BitAggregate | _: HyperLogLogPlusPlus => true
Review comment:
I see your point. I'll remove that then, but keep the `BitAggregate`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu closed pull request #29740: [SPARK-32868][SQL] Add more order irrelevant aggregates to EliminateSorts
Posted by GitBox <gi...@apache.org>.
maropu closed pull request #29740:
URL: https://github.com/apache/spark/pull/29740
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29740: [SPARK-32868][SQL]Add more order irrelevant aggregates to EliminateSorts
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29740:
URL: https://github.com/apache/spark/pull/29740#issuecomment-691656140
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tanelk commented on pull request #29740: [SPARK-32868][SQL]Add more order irrelevant aggregates to EliminateSorts
Posted by GitBox <gi...@apache.org>.
tanelk commented on pull request #29740:
URL: https://github.com/apache/spark/pull/29740#issuecomment-691656076
cc @cloud-fan , @gatorsmile and @wzhfy, you reviewed `EliminateSorts` before
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29740: [SPARK-32868][SQL] Add more order irrelevant aggregates to EliminateSorts
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29740:
URL: https://github.com/apache/spark/pull/29740#issuecomment-691823838
**[Test build #128613 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128613/testReport)** for PR 29740 at commit [`c2f191e`](https://github.com/apache/spark/commit/c2f191ea2d16c00ff6df3778037ed290d86cf9b6).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29740: [SPARK-32868][SQL] Add more order irrelevant aggregates to EliminateSorts
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29740:
URL: https://github.com/apache/spark/pull/29740#issuecomment-692056628
**[Test build #128632 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128632/testReport)** for PR 29740 at commit [`20323c8`](https://github.com/apache/spark/commit/20323c846f54ce4f27c8c34e0b0b51ae4ff510dc).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29740: [SPARK-32868][SQL] Add more order irrelevant aggregates to EliminateSorts
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29740:
URL: https://github.com/apache/spark/pull/29740#issuecomment-691754716
**[Test build #128613 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128613/testReport)** for PR 29740 at commit [`c2f191e`](https://github.com/apache/spark/commit/c2f191ea2d16c00ff6df3778037ed290d86cf9b6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29740: [SPARK-32868][SQL] Add more order irrelevant aggregates to EliminateSorts
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29740:
URL: https://github.com/apache/spark/pull/29740#issuecomment-691824405
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29740: [SPARK-32868][SQL] Add more order irrelevant aggregates to EliminateSorts
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29740:
URL: https://github.com/apache/spark/pull/29740#issuecomment-691754913
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29740: [SPARK-32868][SQL] Add more order irrelevant aggregates to EliminateSorts
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29740:
URL: https://github.com/apache/spark/pull/29740#issuecomment-691824405
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29740: [SPARK-32868][SQL] Add more order irrelevant aggregates to EliminateSorts
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29740:
URL: https://github.com/apache/spark/pull/29740#issuecomment-692058465
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org